Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Nov 2019 01:10:20 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 241928] multimedia/handbrake: fix build on GCC architectures
Message-ID:  <bug-241928-7788-8Gtk0IteEd@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-241928-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-241928-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241928

--- Comment #1 from Yuichiro NAITO <naito.yuichiro@gmail.com> ---
Would you tell me what kind of architecture for your target?

Please remember that upstream project clearly says they will support only f=
or
amd64 architecture.
HandBrake is not intended to work on other architectures.
But I respect FreeBSD support policy that i386 is Tier 1,
I added patches for i386 architecture.

If you keep maintain on your architecture, I will work with you.

I will reply on your comment.

> Use C11 compiler. Needed by ffmpeg.

  It's no problem for me.

> Correct comment typo.

  That's right, it's my mistake.

> Remove two Linux-specific includes from ppc_cpudetect.c that cause build =
errors, since we don't have them.

  HandBrake 1.3.0 changes to use libvpx from Ports.
  PR #241902 should obsolete this patch.

> Merge upstream patch for building x265 on non-x86.

  HandBrake 1.3.0 updates x265 to 3.2.1.
  As you say, it will be fixed by upstream and PR #241902 will fix this.

> Don't link to libc++ when building with GCC.- compiler:c11

  It has complicated reason.
  I think it is necessary for amd64/i386 when HandBrake is built by gcc.
  I would like to make this patch for specific architecture.

  The reason is shown in following GitHub issue.

  https://github.com/HandBrake/HandBrake/issues/1674

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-241928-7788-8Gtk0IteEd>