From owner-freebsd-bugs@FreeBSD.ORG Mon Oct 13 13:40:07 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 21E3510656DE for ; Mon, 13 Oct 2008 13:40:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EB0C18FC1E for ; Mon, 13 Oct 2008 13:40:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id m9DDe6Cw047532 for ; Mon, 13 Oct 2008 13:40:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id m9DDe65g047531; Mon, 13 Oct 2008 13:40:06 GMT (envelope-from gnats) Resent-Date: Mon, 13 Oct 2008 13:40:06 GMT Resent-Message-Id: <200810131340.m9DDe65g047531@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeremy Chadwick Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C03D31065695 for ; Mon, 13 Oct 2008 13:31:10 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from QMTA03.emeryville.ca.mail.comcast.net (qmta03.emeryville.ca.mail.comcast.net [76.96.30.32]) by mx1.freebsd.org (Postfix) with ESMTP id A74D78FC1C for ; Mon, 13 Oct 2008 13:31:10 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from OMTA12.emeryville.ca.mail.comcast.net ([76.96.30.44]) by QMTA03.emeryville.ca.mail.comcast.net with comcast id SCs61a00D0x6nqcA3DXARl; Mon, 13 Oct 2008 13:31:10 +0000 Received: from koitsu.dyndns.org ([69.181.141.110]) by OMTA12.emeryville.ca.mail.comcast.net with comcast id SDX91a0042P6wsM8YDX9h7; Mon, 13 Oct 2008 13:31:09 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id 00911C9419; Mon, 13 Oct 2008 06:31:08 -0700 (PDT) Message-Id: <20081013133109.00911C9419@icarus.home.lan> Date: Mon, 13 Oct 2008 06:31:08 -0700 (PDT) From: Jeremy Chadwick To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/128058: pkg_create -n flag does not work (lack of code) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jeremy Chadwick List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Oct 2008 13:40:07 -0000 >Number: 128058 >Category: bin >Synopsis: pkg_create -n flag does not work (lack of code) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Oct 13 13:40:06 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 7.1-PRERELEASE amd64 >Organization: >Environment: System: FreeBSD icarus.home.lan 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #0: Thu Oct 2 03:04:20 PDT 2008 root@icarus.home.lan:/usr/obj/usr/src/sys/PDSMI_PLUS_RELENG_7_amd64 amd64 >Description: The -n flag is documented in the pkg_create(1) man page for 7.1-PRERELEASE as being "no clobber" mode, but there's no code for it. It's listed in the opts[] array, but there's no csupport for it in main(). This is specific to RELENG_7. >How-To-Repeat: Try to use pkg_create -n, you'll receive usage syntax. >Fix: The necessary code nees to be put in place. The below patch is based on what's in CURRENT. http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.sbin/pkg_install/create/main.c.diff?r1=1.45;r2=1.46;f=h --- /usr/src/usr.sbin/pkg_install/create/main.c 2008-06-17 03:47:24.000000000 -0700 +++ ./main.c 2008-10-13 06:29:53.840396271 -0700 @@ -208,6 +208,10 @@ Recursive = TRUE; break; + case 'n': + Regenerate = FALSE; + break; + case 0: if (Help) usage(); >Release-Note: >Audit-Trail: >Unformatted: