Date: Tue, 22 Jul 2008 11:16:57 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Jaakko Heinonen <jh@saunalahti.fi> Cc: freebsd-fs@freebsd.org, ighighi@gmail.com Subject: Re: birthtime initialization Message-ID: <37898.1216725417@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 22 Jul 2008 10:57:19 %2B0300." <20080722075718.GA1881@a91-153-120-204.elisa-laajakaista.fi>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20080722075718.GA1881@a91-153-120-204.elisa-laajakaista.fi>, Jaakko Heinonen writes: >On 2008-06-02, Bruce Evans wrote: >[about patch for ext2fs in PR kern/122047] >> % + vap->va_birthtime.tv_sec = 0; >> % + vap->va_birthtime.tv_nsec = 0; >> >> This is unrelated and should be handled centrally. Almost all file >> systems get this wrong. Most fail to set va_birthtime, so stat() >> returns kernel stack garbage for st_birthtime. ffs1 does the same >> as the above. msdosfs does the above correctly, by setting tv_sec to >> (time_t)-1 in unsupported cases. > >How about this patch? Looks like something Kirk forgot to me. We want to macroize the NOVAL for timespec instead of spreading -1 casts all over. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?37898.1216725417>