From owner-freebsd-libh Thu Sep 26 6:16: 5 2002 Delivered-To: freebsd-libh@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 783F637B401 for ; Thu, 26 Sep 2002 06:16:03 -0700 (PDT) Received: from aeimail.aei.ca (aeimail.aei.ca [206.123.6.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 380E643E6A for ; Thu, 26 Sep 2002 06:16:02 -0700 (PDT) (envelope-from anarcat@anarcat.ath.cx) Received: from shall.anarcat.ath.cx (0vpx9fhwjezx05dn@hv-hs-38-172.aei.ca [216.221.38.172]) by aeimail.aei.ca (8.11.6/8.10.1) with ESMTP id g8QDG1307201; Thu, 26 Sep 2002 09:16:01 -0400 (EDT) Received: from lenny.anarcat.ath.cx (lenny.anarcat.ath.cx [192.168.0.4]) by shall.anarcat.ath.cx (Postfix) with SMTP id 5021F401; Thu, 26 Sep 2002 09:19:59 -0400 (EDT) Received: by lenny.anarcat.ath.cx (sSMTP sendmail emulation); Thu, 26 Sep 2002 09:15:08 -0400 Date: Thu, 26 Sep 2002 09:15:08 -0400 From: The Anarcat To: Alexander Langer Cc: freebsd-libh@FreeBSD.org Subject: Re: cvs commit: libh/lib/sysinstall Feature.cc Message-ID: <20020926131508.GB43108@lenny.anarcat.ath.cx> Mail-Followup-To: The Anarcat , Alexander Langer , freebsd-libh@FreeBSD.org References: <200209261105.g8QB5jYs048922@rtp1.SlowBlink.Com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hHWLQfXTYDoKhP50" Content-Disposition: inline In-Reply-To: <200209261105.g8QB5jYs048922@rtp1.SlowBlink.Com> User-Agent: Mutt/1.5.1i Sender: owner-freebsd-libh@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --hHWLQfXTYDoKhP50 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Aaarrghh... I struggled a lot with this class to make feature comparison deterministic. I'm not sure this is the good path to take. I suggest you back this out. Some packages *do* use letters in their packages, but I don't think we should include them, because they can't essentially be used in comparisons.=20 I mean, this all comes back to: 1.a.4c.3 ?=3D 1.2.3c and such. By not allowing strings in version, you make a stricter version format that is more foolproof. Can you prove that this version format is deterministic? Also please see the numerous mails I sent on the least WRT that, and that I had no answer for. Thanks A. On Thu Sep 26, 2002 at 07:05:45AM -0400, Alexander Langer wrote: > alex 2002/09/26 07:05:45 EDT >=20 > Modified files: > lib/sysinstall Feature.cc=20 > Log: > Allow feature versions of the type > [0-9][0-9A-Za-z]*([._][0-9A-Za-z]+)* > =20 > - at least one digit at the beginning > - then digits or letters are allowed (some packages use them > for versioning *sigh*) > - dots or underscores are allowed, but not at the end > of the version string > =20 > Note that we probably want to check compare serials of > packages to find out if a package is newer/older/equal. > =20 > Revision Changes Path > 1.24 +15 -6 libh/lib/sysinstall/Feature.cc >=20 >=20 > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-libh" in the body of the message >=20 --=20 =46rom the age of uniformity, from the age of solitude, from the age of Big Brother, from the age of doublethink - greetings! --hHWLQfXTYDoKhP50 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE9kwhbttcWHAnWiGcRAlyXAJoDV/85uK7h0MwvudHSHGOGWF8HfgCggKeb 0l8+FxbrBhJ3RoyP89jDWPY= =xoUb -----END PGP SIGNATURE----- --hHWLQfXTYDoKhP50-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-libh" in the body of the message