From owner-freebsd-virtualization@FreeBSD.ORG  Mon Jul 14 23:13:23 2008
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C8CEC1065677
	for <freebsd-virtualization@freebsd.org>;
	Mon, 14 Jul 2008 23:13:23 +0000 (UTC)
	(envelope-from jamie@gritton.org)
Received: from gritton.org (gritton.org [161.58.222.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 9B8318FC1B
	for <freebsd-virtualization@freebsd.org>;
	Mon, 14 Jul 2008 23:13:23 +0000 (UTC)
	(envelope-from jamie@gritton.org)
Received: from guppy.corp.verio.net (fw.oremut02.us.wh.verio.net
	[198.65.168.24]) (authenticated bits=0)
	by gritton.org (8.13.6.20060614/8.13.6) with ESMTP id m6ENDJhZ021854;
	Mon, 14 Jul 2008 17:13:19 -0600 (MDT)
Message-ID: <487BDD8A.9060300@gritton.org>
Date: Mon, 14 Jul 2008 17:13:14 -0600
From: James Gritton <jamie@gritton.org>
User-Agent: Thunderbird 2.0.0.9 (X11/20080228)
MIME-Version: 1.0
To: Julian Elischer <julian@elischer.org>
References: <487BD8BE.1040609@gritton.org> <487BDC7A.8040606@elischer.org>
In-Reply-To: <487BDC7A.8040606@elischer.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV version 0.93, clamav-milter version 0.93 on gritton.org
X-Virus-Status: Clean
Cc: freebsd-virtualization@freebsd.org
Subject: Re: IFNET_WLOCK missing from if_reassign_common
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
	<freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jul 2008 23:13:23 -0000

Sure - hopefully the soon to be announced jail_set changes for vimage 
will be pronounced acceptable, and then I can merge them in.

- Jamie


Julian Elischer wrote:
> James Gritton wrote:
>> In testing jail_set_vimage, I found that moving a network interface 
>> cause a assertion failure in ifnet_setbyindex.  It turns out that 
>> if_reassign_common in kern_vimage.c should be locking IFNET_WLOCK.  
>> I'm including a patch that locks it in the same way it's done in 
>> if_alloc (which seems to be the inspiration for much of this code).
>>
>> - Jamie
>
> cool,
>
> Jamie, do you want (write) access to the actual vimage tree in p4?