From owner-freebsd-current@freebsd.org Sun Jul 15 18:43:07 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA028104A92C for ; Sun, 15 Jul 2018 18:43:06 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B28C92CF6; Sun, 15 Jul 2018 18:43:06 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id elyxfrTfP5HxqelyzfiBOb; Sun, 15 Jul 2018 12:42:58 -0600 X-Authority-Analysis: v=2.3 cv=BMcHU2YG c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=R9QF1RCXAYgA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=CSz7DQG5eDtsI0kICj4A:9 a=tAd33UIhWrEktjdv:21 a=R_ztdkZfx0kpGRkD:21 a=CjuIK1q_8ugA:10 a=hDOnJyz3TxZynsWVIHgA:9 a=3dQZWuVdzU99YDHo:21 a=Lcd6fi8UkDo-vK6N:21 a=KazVbFF-DrvXHMnm:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from [25.81.209.115] (S0106002401cb186f.gv.shawcable.net [70.67.125.17]) by spqr.komquats.com (Postfix) with ESMTPSA id 4965AE50; Sun, 15 Jul 2018 11:42:55 -0700 (PDT) MIME-Version: 1.0 From: Cy Schubert Subject: RE: [PATCH] Recent libm additions Date: Sun, 15 Jul 2018 11:43:04 -0700 To: Ian Lepore , Warner Losh , "K. Macy" CC: Steve Kargl , FreeBSD Current Message-Id: <20180715184255.4965AE50@spqr.komquats.com> X-CMAE-Envelope: MS4wfCbE6tp6vLsZdig9OR7jhU1Fw3ddGoB3JJ7uU3xSkAIJlPolkpwlypK372l7b5/FIJbyPcJBnve1/Qx/x+21Tr9m9zHst8djLOgP36qRquCe0fs9NtlB Fm7Ruz2kr+0FhihTIrfRrX5E0l2UMKDEmGsPySZ+5ujwI8JA9g464ZArZwzsp8crUOMQuo/AsaTaUMwznndTfiJ5gXsJklGiCyJEHtkac+Lil4mjyrZHiOzE vDoo11ykROMdv73+sDdOfOT5tAb5BUdFU8n5/rymzTXrEOSXJSxSXRjGYxOWaFFxrETy88GlNhXlDNCIlzq7mnsc84ezyukdqB88LGqSgNEoftxV18fpb4Pu tK6dqwl1TpE5WXCDrqwbEn2SuPxuLw7ggsYRl9yTdLTsIzpj2pE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 18:43:07 -0000 I don't think it makes sense for a non-committer to have a lock on anything= in base. However a request for review makes a lot of sense. If a non-commi= tter or former committer is the SME on a particular subject it's best that = they be consulted even if they don't request it. IMO more input is better. = Where better to document this than in MAINTAINERS. Having said all this. If a person is a former committer and it's not docume= nted, how are we to know? If people agree, should we start documenting SMEs in MAINTAINERS? --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: Ian Lepore Sent: 15/07/2018 11:08 To: Warner Losh; K. Macy Cc: Steve Kargl; FreeBSD Current Subject: Re: [PATCH] Recent libm additions On Sun, 2018-07-15 at 11:55 -0600, Warner Losh wrote: > On Sun, Jul 15, 2018, 11:23 AM K. Macy wrote: >=20 > >=20 > > >=20 > > >=20 > > > Well, actually, the functions in polevll.c should have been > > > copied > > > into ld80/e_powl.c, and polevall.c should never have been > > > committed. > > > Unfortunately, the code was not reviewed for correctness. > > That is not correct. Please stop repeating it. Bruce Evans and John > > Baldwin were both looped in. Neither made this observation. > >=20 > Steve is the fp guy these days. And it wasn't reviewed by him. He's > mad you > cut him out of the loop. Arguing about pedantic points of process > does no > one any good. >=20 > Warner On the other hand, what information is there for someone to know that Steve should be involved in a review? There is nothing in MAINTAINERS. The review was on phab for almost a month, and phab is supposedly the preferred way to do reviews these days. Steve is no longer a committer, but that doesn't preclude him having a phab account and participating in reviews. If he doesn't like using phab (and I can certainly understand that POV), an entry in MAINTAINERS would still be helpful, unless we have a rule that only committers can be listed in there. -- Ian _______________________________________________ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"