From owner-freebsd-current@FreeBSD.ORG Fri Dec 16 21:44:03 2005 Return-Path: X-Original-To: freebsd-current@FreeBSD.ORG Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE70316A420 for ; Fri, 16 Dec 2005 21:44:03 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mail2.fluidhosting.com [204.14.90.12]) by mx1.FreeBSD.org (Postfix) with SMTP id 26A3E43D5D for ; Fri, 16 Dec 2005 21:44:02 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 89280 invoked by uid 399); 16 Dec 2005 21:44:00 -0000 Received: from localhost (HELO ?192.168.0.3?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 16 Dec 2005 21:44:00 -0000 Message-ID: <43A3351E.8010005@FreeBSD.org> Date: Fri, 16 Dec 2005 13:43:58 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5 (X11/20051206) MIME-Version: 1.0 To: Jeremie Le Hen References: <200512022006.jB2K67AK078509@repoman.freebsd.org> <20051203004057.GA20872@nagual.pp.ru> <4390EFB6.3090307@FreeBSD.org> <20051203012324.GA34147@nagual.pp.ru> <4390F9A2.208@FreeBSD.org> <20051216013955.GW3512@obiwan.tataz.chchile.org> In-Reply-To: <20051216013955.GW3512@obiwan.tataz.chchile.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.ORG Subject: Re: cvs commit: src/etc rc rc.shutdown rc.subr src/etc/rc.d localpkg src/sys/sys param.h X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2005 21:44:04 -0000 Jeremie Le Hen wrote: > When I first read your mail on arch@ I didn't think about it, but now > I'm reading this thread, it stirs my mind. RELENG_6 is supposed to > be very stable. Though the ultimate stability would be to stay in > RELENG_6_0, I think MFC'ing those changes to RELENG_6 would cause much > pain to system administrators who will be upgrading from 6.0 to 6.1 if > they don't not update their apache13 port accordingly. Thank you for putting more thought into this topic. :) Your concerns are valid, and that is why the code was changed shortly after I introduced it into HEAD to run all scripts in a subshell, which is what was happening prior to the changes being introduced. The only changes that are present now are to the order in which the scripts are run at boot time, and while there have been no reports of problems since the change I mentioned above was made, any problems that do exist in that area will need to be addressed in any case, since that is fundamental to what is being added (the ability to run local boot scripts in the base rcorder). There is another aspect to this that you should be aware of. A group of stalwart developers have stepped forward and agreed to work on converting the boot scripts that are still in the old style, and helping to fix any of the new style scripts that have problems. They are also working on changes to the ports infrastructure to handle installing the boot scripts as foo instead of foo.sh on RELENG_6 and HEAD systems that have already had the update. Meanwhile, while this work is in progress, all scripts will still be run in a subshell, so there is virtually zero danger that a wonky script will cause the boot to fail. I hope that this information helps you feel more comfortable with this change. I agree that we want to keep FreeBSD's standards high, and that we don't want to violate the release engineering principles that our users have come to rely on. That is why this change will not be ported back to RELENG_5. On the other hand, this is still early enough in the release cycle for RELENG_6, and there is enough time between now and when the 6.1 release will be cut to ferret out any remaining problems, that we feel it's safe to move forward with this. And, if it turns out that I'm wrong, we can easily back the changes out in RELENG_6 and keep this change on hold for the 7.x-RELEASE cycle. Regards, Doug -- This .signature sanitized for your protection