From owner-freebsd-sysinstall@FreeBSD.ORG Mon Oct 24 13:26:10 2011 Return-Path: Delivered-To: freebsd-sysinstall@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 45A01106564A; Mon, 24 Oct 2011 13:26:10 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from adsum.doit.wisc.edu (adsum.doit.wisc.edu [144.92.197.210]) by mx1.freebsd.org (Postfix) with ESMTP id 199278FC13; Mon, 24 Oct 2011 13:26:09 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth1.wiscmail.wisc.edu by smtpauth1.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) id <0LTK00I0GNZLD400@smtpauth1.wiscmail.wisc.edu>; Mon, 24 Oct 2011 08:26:09 -0500 (CDT) Received: from comporellon.tachypleus.net (adsl-75-50-90-239.dsl.mdsnwi.sbcglobal.net [75.50.90.239]) by smtpauth1.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) with ESMTPSA id <0LTK008YINZJ2610@smtpauth1.wiscmail.wisc.edu>; Mon, 24 Oct 2011 08:26:08 -0500 (CDT) Date: Mon, 24 Oct 2011 08:26:07 -0500 From: Nathan Whitehorn In-reply-to: <21148.1319446588@critter.freebsd.dk> To: Poul-Henning Kamp Message-id: <4EA5676F.4000205@freebsd.org> X-Spam-Report: AuthenticatedSender=yes, SenderIP=75.50.90.239 X-Spam-PmxInfo: Server=avs-9, Version=5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.10.24.131514, SenderIP=75.50.90.239 References: <21148.1319446588@critter.freebsd.dk> User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:7.0) Gecko/20110928 Thunderbird/7.0 Cc: freebsd-bugs@freebsd.org, freebsd-sysinstall@freebsd.org Subject: Re: bin/161926: bsdinstall(8): disk layout trouble X-BeenThere: freebsd-sysinstall@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Sysinstall Work List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2011 13:26:10 -0000 On 10/24/11 03:56, Poul-Henning Kamp wrote: > In message<4EA47456.7090008@freebsd.org>, Nathan Whitehorn writes: >> On 10/23/11 13:15, Poul-Henning Kamp wrote: >> There's not actually too much need for them, and so they never seemed >> pressing. Pressing control-C/choosing "cancel"/etc. will either skip >> steps that can be returned to later (post-extraction) or return to the >> beginning of the installation, which is where you already were, > Let me just note that neither the overall structure nor where I would > end up by pressing Ctrl-C was not even remotely obvious to this > particular user. Well, that can probably be improved. Robert Bonomi's suggestion was very good as well, and I'll see what can be done there. There are a few related things, as well. >>>>> Active partition is the last one created ? >>>>> There is no place I can see it ? >>>>> There is no place I can change it ? >>>> Active partition is the last bootable (e.g. freebsd) partition you >>>> created, yes. >>> That is *totally* bogus, at the very least, make it the first one. >> The UI problem is actually hard, and the correct solution without a UI >> solution is non-obvious. The usual use case, where only one MBR >> partition of type freebsd is added, works perfectly well. I'll try to >> find a reasonable solution to this, but have very little time at the >> moment -- patches would be much appreciated. > The fact that is is hard to do right, seems an incredibly lousy > excuse for doing something totally counter-intutive. Well, I didn't find it counterintuitive, but it is a lousy excuse. > Systems with more than one MBR partition are quite common in the > wild in my experience. But more than one FreeBSD MBR partition, with a label inside it? > How about you set the active flag on whatever parition contains the > / filesystem as part of final cleanup ? > > I'm not going to be sending patches: I solved this problem once > according to the priorities at the time, you get to solve it this > time :-) > > My input should simply count as a single old grumbling fart, and > if you think he is totally out of touch, you get to ignore him. > Well, you're a grumbling old fart who's usually right. The behavior right now is that any sub-partitioning that you do in the installer gets marked active. It's a little more complicated to turn the install bootcode flag on only if a sub-partition is root, but not much, so that sounds like a good solution. -Nathan