From owner-svn-src-head@freebsd.org Wed Jul 8 22:32:04 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B54A996B60 for ; Wed, 8 Jul 2015 22:32:04 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0A7CD1C0F for ; Wed, 8 Jul 2015 22:32:03 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by pdbep18 with SMTP id ep18so152758851pdb.1 for ; Wed, 08 Jul 2015 15:32:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=lD7TGnlSMvdYL9FgLkpabXTGlRW1Iaok2bn1AY0E7gg=; b=m89N5E/6Ymkw1ly4+BzO7ooin0EO1CFmr10gJTQbJwjYmDC8yKR3X1bFDLBxxpFUX7 WYyiIocoEztmUj5CR2sD06EOdJTLJhE6wt15+QnIPp09MnlU3aTogTmv4To3NIwhL6bX TxB39rTZOqly+IKRFL+BjmJS+zmz9qNWspiEdKsRnE4FlBP3/kavbD92ERdzhZsyMzWO qhEbyFJsUnucfMZJQBquYVui7Ds7ajNRrVrCSP4j0etWCp6OReCB48ubgfskOllJHI0P z3gNkRpMh+ML17GJLvLki6cAlOx6qQrt+Pkhbl9kOS7RAWeV32X1v/uSDZIpSSby/HZv CuIA== X-Gm-Message-State: ALoCoQkaiJiQdGU209GVJTEFYZ/C+1pu27WXlk0SGMa0UtAp4+KEzPjm6ZTzkrHQD8UZrKQhCMFt X-Received: by 10.70.100.168 with SMTP id ez8mr24578812pdb.129.1436394722785; Wed, 08 Jul 2015 15:32:02 -0700 (PDT) Received: from [10.64.26.63] ([69.53.236.236]) by smtp.gmail.com with ESMTPSA id r4sm3623466pap.8.2015.07.08.15.32.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 08 Jul 2015 15:32:01 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r285284 - head/lib/liblzma Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Content-Type: multipart/signed; boundary="Apple-Mail=_3FF6BEFB-3861-411F-BB9F-D766CCE92F69"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5 From: Warner Losh In-Reply-To: Date: Wed, 8 Jul 2015 16:31:58 -0600 Cc: Pedro Giffuni , Luigi Rizzo , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <95059F59-AE24-42A3-A43B-5B08903B68E2@bsdimp.com> References: <201507081836.t68IacJu069563@repo.freebsd.org> <559D9172.9040305@FreeBSD.org> To: Adrian Chadd X-Mailer: Apple Mail (2.2102) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 22:32:04 -0000 --Apple-Mail=_3FF6BEFB-3861-411F-BB9F-D766CCE92F69 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Not in this context, no. Nor should you want to in this context (inside = the compiling module). Generally in Makefiles it would be a bad idea too, but there=E2=80=99s = sometimes you need to know. But there=E2=80=99s currently not any such instances in the tree. Warner > On Jul 8, 2015, at 4:04 PM, Adrian Chadd = wrote: >=20 > Is there a blessed way to see whether the compiler we're using is an > external compiler, or an internal one? >=20 > eg, the version check isn't enough - it's just a number. how do I know > if it's freebsd clang versus upstream clang? > (Or in my instance, freebsd-gcc versus upstream-gcc.) >=20 >=20 > -a >=20 >=20 > On 8 July 2015 at 14:09, Pedro Giffuni wrote: >>=20 >>=20 >> On 07/08/15 13:36, Luigi Rizzo wrote: >>>=20 >>> Author: luigi >>> Date: Wed Jul 8 18:36:37 2015 >>> New Revision: 285284 >>> URL: https://svnweb.freebsd.org/changeset/base/285284 >>>=20 >>> Log: >>> only enable immintrin when clang is used. The base gcc does not = support >>> it. >>> Reviewed by: delphij >>>=20 >>> Modified: >>> head/lib/liblzma/config.h >>>=20 >>> Modified: head/lib/liblzma/config.h >>>=20 >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/lib/liblzma/config.h Wed Jul 8 18:12:24 2015 = (r285283) >>> +++ head/lib/liblzma/config.h Wed Jul 8 18:36:37 2015 = (r285284) >>> @@ -150,7 +150,8 @@ >>> #define HAVE_ICONV 1 >>> /* Define to 1 if you have the header file. */ >>> -#if defined(__FreeBSD__) && defined(__amd64__) >>> +/* FreeBSD - only with clang because the base gcc does not support = it */ >>> +#if defined(__clang__) && defined(__FreeBSD__) && = defined(__amd64__) >>> #define HAVE_IMMINTRIN_H 1 >>> #endif >>>=20 >>=20 >> FWIW, gcc 4.3+ does have it so this may some undesired (but hidden) >> effect when building with an external gcc. >>=20 >> Pedro. >>=20 >=20 --Apple-Mail=_3FF6BEFB-3861-411F-BB9F-D766CCE92F69 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVnaTeAAoJEGwc0Sh9sBEAL18QAJLSYP+nWC34q6dYxJ6Nh+r6 ziy1atDiTdKcQgf5ldqO+LSfmf2FP1+bzjpwtZEFtUbqwUCOL/3GK1WWmgTWlp3A 07BXlud3/9YeC4o71b86uUWerjGbHLqYWjBaMJTNsQqM3uYC4jYukcpTnGTKCAOv nRtc0HJr8iYgL5zT6MxjdLxm0eq5gNxMGPaZvc9xqQQsW8QQEFigxSaOo4ZzqoQl 3sSw4yzOOPQaFJ5ES8RSDki7NzBx2WwXaMy2RGeXXZ9P48M55RLdVzlFIAupYXgv 6vCCEWS8IX9OyZZE6T2B+8Hghawukc9qBbzt0IsIDDwEd1XYfJFy8sXnPdAX+2Wt J5ivNpM0SRL9fBa/627Iwz0bKa2BDqWbdAbMO0SAATVb1Rnx6jy3Bn5KB6AMdLlW liMlvqPC2yPzVD0czqIK/dSkT8DnzlFb5HpQSf6id1eqWS9EjdPDtwq309y+1hDS uFQ2ofAQcKF+aQwCoS6c2T0AmuVgZc4nbPbhU7v1Xr/fv4S5V14MfXluGAwjWFlW tfdwy/7oQZ5ZqScrmthiyYSSQU7Wx+fDsikCaDaa34v9v7SMk2SfcqNwglRoNlnN izUasKHbfuh39JE6zD0hBtveuL1uDYY3g8c8A17FCL1FJdcm6HvjD7VcAk3TuOiL CoW3ZGxTr+zzrLcCk67f =5JOb -----END PGP SIGNATURE----- --Apple-Mail=_3FF6BEFB-3861-411F-BB9F-D766CCE92F69--