Date: Sat, 7 Oct 2000 04:07:23 +0200 (CEST) From: mbendiks@eunet.no To: FreeBSD-gnats-submit@freebsd.org Subject: kern/21805: [patches] Fix erronous comment in msdosfs Message-ID: <200010070207.EAA23533@suiram.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 21805
>Category: kern
>Synopsis: msdosfs_vnops comments are incorrect wrt locking
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: doc-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Oct 06 21:40:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator: Marius Bendiksen
>Release: FreeBSD 4.1-RELEASE i386
>Organization:
n/a
>Environment:
not relevant.
>Description:
In /sys/msdosfs/msdosfs_vnops.c, function msdosfs_rename(), the
comments erronously claim that the parent is locked. This isn't
correct, according to the UFS code and documentation. Also, the
code doesn't do it anyway, so someone probably just forgot it.
>How-To-Repeat:
not relevant.
>Fix:
diff -u4 in /sys/msdosfs, output follows:
--- msdosfs_vnops.c.orig Sun Sep 24 14:20:20 2000
+++ msdosfs_vnops.c Sun Sep 24 14:21:54 2000
@@ -865,11 +865,9 @@
return (error);
}
/*
- * DOS filesystems don't know what links are. But since we already called
- * msdosfs_lookup() with create and lockparent, the parent is locked so we
- * have to free it before we return the error.
+ * DOS filesystems don't know what links are.
*/
static int
msdosfs_link(ap)
struct vop_link_args /* {
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010070207.EAA23533>