Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Jan 2002 16:24:18 -0800
From:      Alfred Perlstein <alfred@FreeBSD.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern sys_generic.c
Message-ID:  <20020116162418.P26067@elvis.mu.org>
In-Reply-To: <XFMail.020116160036.jhb@FreeBSD.org>; from jhb@FreeBSD.org on Wed, Jan 16, 2002 at 04:00:36PM -0800
References:  <200201162133.g0GLXfA36921@freefall.freebsd.org> <XFMail.020116160036.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* John Baldwin <jhb@FreeBSD.org> [020116 16:01] wrote:
> 
> On 16-Jan-02 Alfred Perlstein wrote:
> > alfred      2002/01/16 13:33:41 PST
> > 
> >   Modified files:
> >     sys/kern             sys_generic.c 
> >   Log:
> >   Fix giant handling in pwrite(2), I forgot to release it when finishing
> >   the syscall.
> 
> Uh, this isn't correct.  fdrop() can call fo_close() can call down into VFS
> and do a vrele(), so fdrop() still needs Giant.  If you aren't holding Giant
> across fdrop() in a few places that might explain the vput(0x0) panics.

Ugh, I'll get to this tonight unless you want to tackle it now.

-Alfred

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020116162418.P26067>