Date: Sat, 13 Mar 2010 20:25:29 +0800 From: Earl Lapus <earl.lapus@gmail.com> To: freebsd-net@freebsd.org Subject: [ping6] freeaddrinfo() Message-ID: <604f76121003130425u62764f59wa88b398f15540b61@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
--00504502d91858555e0481adbec4 Content-Type: text/plain; charset=ISO-8859-1 Hi, I was browsing through the ping6 code and I noticed that one particular call to getaddrinfo() didn't have a freeaddrinfo() pair. All calls to getaddrinfo() should have an equivalent freeaddrinfo(), right? Attached is a patch that "tries-to-resolve" this very small issue (applies cleanly on an 8.0p2 kernel source). Also, I'm not not 100% sure if that is the correct place to call freeaddrinfo() - I hope someone on the list would be kind enough to have look. Cheers! -- There are seven words in this sentence. --00504502d91858555e0481adbec4 Content-Type: text/x-patch; charset=US-ASCII; name="ping6.diff" Content-Disposition: attachment; filename="ping6.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g6qe7c3q0 ZGlmZiAtcnVOIC4uL3NyYy9zYmluL3Bpbmc2L3Bpbmc2LmMgLi4vc3JjLm1vZC9zYmluL3Bpbmc2 L3Bpbmc2LmMKLS0tIC4uL3NyYy9zYmluL3Bpbmc2L3Bpbmc2LmMJMjAwOS0xMC0yNSAwOToxMDoy OS4wMDAwMDAwMDAgKzA4MDAKKysrIC4uL3NyYy5tb2Qvc2Jpbi9waW5nNi9waW5nNi5jCTIwMTAt MDMtMTMgMTk6NDY6NDUuMDAwMDAwMDAwICswODAwCkBAIC02MzUsNiArNjM1LDggQEAKIAkgICAg cmVzLT5haV9wcm90b2NvbCkpIDwgMCkKIAkJZXJyKDEsICJzb2NrZXQiKTsKIAorCWZyZWVhZGRy aW5mbyhyZXMpOworCiAJLyogc2V0IHRoZSBzb3VyY2UgYWRkcmVzcyBpZiBzcGVjaWZpZWQuICov CiAJaWYgKChvcHRpb25zICYgRl9TUkNBRERSKSAmJgogCSAgICBiaW5kKHMsIChzdHJ1Y3Qgc29j a2FkZHIgKikmc3JjLCBzcmNsZW4pICE9IDApIHsK --00504502d91858555e0481adbec4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?604f76121003130425u62764f59wa88b398f15540b61>