From owner-freebsd-net@FreeBSD.ORG  Mon Jan 23 21:09:36 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 66440106566B
	for <freebsd-net@freebsd.org>; Mon, 23 Jan 2012 21:09:36 +0000 (UTC)
	(envelope-from rozhuk.im@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id EC3758FC12
	for <freebsd-net@freebsd.org>; Mon, 23 Jan 2012 21:09:35 +0000 (UTC)
Received: by bkbc12 with SMTP id c12so3723620bkb.13
	for <freebsd-net@freebsd.org>; Mon, 23 Jan 2012 13:09:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=reply-to:from:to:subject:date:message-id:mime-version:content-type
	:content-transfer-encoding:x-mailer:thread-index:content-language;
	bh=y9Q4hHD4GZd5zmns8nIvLMTUjSyD4jp0OyuhRS4i6PA=;
	b=cWTd8xqBPz/VQ9VD9Q54lttq+oCDqqNWSw2PzYX3cw4tjllzE73PRLR4GQchgvLa2x
	aLegowyCe5MlZdjZZxtAnD/RZTi4ChuJYV61sobb3XTB7sWyXtKRRYPPvbbfCaXcWsVa
	AGTsJ0/vryd5kSXoodBgSEVpdSpmo0tRJcOiY=
Received: by 10.204.153.28 with SMTP id i28mr3977037bkw.136.1327352974871;
	Mon, 23 Jan 2012 13:09:34 -0800 (PST)
Received: from rimwks1w7x64 ([31.47.168.205])
	by mx.google.com with ESMTPS id ev5sm28487107bkb.4.2012.01.23.13.09.33
	(version=SSLv3 cipher=OTHER); Mon, 23 Jan 2012 13:09:34 -0800 (PST)
From: rozhuk.im@gmail.com
To: <freebsd-net@FreeBSD.org>
Date: Tue, 24 Jan 2012 06:09:30 +0900
Message-ID: <4f1dcc8e.45c8cc0a.2935.2254@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: AczaE0xCSiCeVikkS4WctDYr2JN5Yw==
Content-Language: ru
Cc: 
Subject: ng_bridge and locks
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Rozhuk.IM@gmail.com
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2012 21:09:36 -0000

Hi!


I found a comment in the code:
	/*
	 * This node has all kinds of stuff that could be screwed by SMP.
	 * Until it gets it's own internal protection, we go through in 
	 * single file. This could hurt a machine bridging beteen two 
	 * GB ethernets so it should be fixed. 
	 * When it's fixed the process SHOULD NOT SLEEP, spinlocks please!
	 * (and atomic ops )
	 */

mtx_init(...., MTX_DEF);
How bad to use netgraph node MTX_DEF mutex?