Date: Tue, 14 Apr 2015 08:22:20 +0200 From: Piotr Robert Konopelko <piotr.konopelko@moosefs.com> To: Ben Woods <woodsb02@gmail.com>, MooseFS FreeBSD Ports <freebsd@moosefs.com> Cc: Fernando =?ISO-8859-1?Q?Apestegu=EDa?= <fernando.apesteguia@gmail.com>, FreeBSD Ports <ports@freebsd.org> Subject: Re: MooseFS Ports for versions 2.0 and 3.0 Message-ID: <21046463.b2bSXRQEol@hp> In-Reply-To: <CAOc73CBrQ-4X2Hhc19CEOcY8K2f06X7EFLGxpuo2V39ZooGaHA@mail.gmail.com> References: <2694094.4JmStLgM3m@hp> <3504531.pypRB0Rknn@hp> <CAOc73CBrQ-4X2Hhc19CEOcY8K2f06X7EFLGxpuo2V39ZooGaHA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello Ben,
Thank you very much for your reply and your time!
We'll implement your notes into our ports :)
--=20
Best regards,
Piotr Robert Konopelko
*MooseFS Technical Support Engineer* | moosefs.com[1]
Nice work putting the ports together - its a good first effort! I have =
a few comments=20
about the format of the ports and bug reports - sorry there are quite a=
few. I don't mean=20
to be picky, but I wanted to minimise the back-and-forth for you to get=
these committed.
1. Updates to existing ports should be attached as patches to the curre=
nt ports tree. The=20
easiest way to do this if you got the ports tree from subversion (not p=
ortsnap) is using the=20
svn diff command. Tick the "patch" option when attaching so we can see =
a nice pretty diff=20
from within bugzilla.
2. New ports should be attached as a shar(1) file. Assuming the port is=
called oneko, cd to=20
the directory above where the oneko directory is located, and then type=
: shar `find oneko`=20
> oneko.shar
3. It's nice for ports for share parts of their configuration, but I do=
n't think it should be=20
called "bsd.port.moosefs.mk[2]" (this implies it is part of the port bu=
ild scripts). A good=20
example of what you could do is devel/libtool. It has a Makefile which =
includes=20
Makefile.common. The devel/libltdl port also=20
includes "${.CURDIR}/../libtool/Makefile.common".
4. @dirrm is now deprecated in pkg-plist. Suggest it is probably easier=
to build this with=20
"make install && make makeplist > pkg-plist". Note that you should chec=
k the plist looks=20
correct, and also delete the top warning line from the generated file.
5. The pkg-descr file should be updated to include a better description=
of the package,=20
and link to the website.
6. Before submitting a port, check that it passes the normal checks by =
installing the ports-
mgmt/portlint program, and running "portlint -AC" in the port directory=
.
7. If you have access to a poudriere installation, you should submit th=
e "poudriere=20
testport" logs showing that this port will build successfully. Myself o=
r other ports=20
contributors/committers can help with this if you do not have access to=
a poudriere=20
installation, but please make sure you have at least tested the build o=
n FreeBSD with a=20
"make install".
Much of this is covered in the porter's handbook. It's a good read if y=
ou haven't already=20
seen it. You can find it here:
https://www.freebsd.org/doc/en/books/porters-handbook/book.html[3]
Note that if you re-submit patches to each bug report, be sure to tick =
the option that it=20
obsolete's the previous patch.
Good luck! :)
Regards,
Ben
On Mon, Apr 13, 2015 at 7:05 PM Piotr Robert Konopelko=20
<piotr.konopelko@moosefs.com[4]> wrote:
Thank you very much for this information.
=20
I posted requests to the FreeBSD bugzilla:
=20
https://bugs.freebsd.org/bugzilla/buglist.cgi?quicksearch=3Dmoosefs&lis=
t_id=3D56910[5]=20
=20
=20
--=20
Best regards,
Piotr Robert Konopelko
*MooseFS Technical Support Engineer* | moosefs.com[1]
Those ports currently have their maintainer fields set to "ports@freebs=
d.org[6]", meaning=20
there is no maintainer.
When you submit the bug report and attach your patch to update the port=
, simply ensure=20
the maintainer email address is updated to your own. You will then be v=
olunteering as=20
the maintainer for those ports.
Regards,Ben
On Thu, 9 Apr 2015 at 9:12 pm Fernando Apestegu=C3=ADa=20
<fernando.apesteguia@gmail.com[7]> wrote:
El 09/04/2015 15:00, "Piotr Robert Konopelko"=20
<piotr.konopelko@moosefs.com[4]>escribi=C3=B3:>> Dear FreeBSD Ports tea=
m,>> On FreeBSD=20
Ports site only ports for MooseFS 1.6.27-5 are available:>=20
https://www.freebsd.org/cgi/ports.cgi?query=3Dmoosefs&stype=3Dall[1][8]=
https://bugs.freebsd.org/bugzilla/[9]
moosefs.com[1][2]>>> --------> [1]=20
https://www.freebsd.org/cgi/ports.cgi?query=3Dmoosefs&stype=3Dall[10]
http://moosefs.com[1]
freebsd-ports@freebsd.org[11] mailing list>=20
http://lists.freebsd.org/mailman/listinfo/freebsd-ports[12]
freebsd-ports-
unsubscribe@freebsd.org[13]"___________________________________________=
____
freebsd-ports@freebsd.org[11] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports[12]
freebsd-ports-unsubscribe@freebsd.org[13]"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?21046463.b2bSXRQEol>