From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Aug 30 16:30:17 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A0F916A420 for ; Tue, 30 Aug 2005 16:30:17 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5FDF243D4C for ; Tue, 30 Aug 2005 16:30:16 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j7UGUGKs059499 for ; Tue, 30 Aug 2005 16:30:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j7UGUGUk059498; Tue, 30 Aug 2005 16:30:16 GMT (envelope-from gnats) Resent-Date: Tue, 30 Aug 2005 16:30:16 GMT Resent-Message-Id: <200508301630.j7UGUGUk059498@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mark Murray Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 968E116A41F for ; Tue, 30 Aug 2005 16:20:27 +0000 (GMT) (envelope-from mark@grondar.org) Received: from storm.uk.FreeBSD.org (storm.uk.FreeBSD.org [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 03CC043D48 for ; Tue, 30 Aug 2005 16:20:26 +0000 (GMT) (envelope-from mark@grondar.org) Received: from storm.uk.FreeBSD.org (uucp@localhost [127.0.0.1]) by storm.uk.FreeBSD.org (8.13.3/8.13.3) with ESMTP id j7UGKPAH048885 for ; Tue, 30 Aug 2005 17:20:25 +0100 (BST) (envelope-from mark@grondar.org) Received: (from uucp@localhost) by storm.uk.FreeBSD.org (8.13.3/8.12.11/Submit) with UUCP id j7UGKN8R048883 for FreeBSD-gnats-submit@freebsd.org; Tue, 30 Aug 2005 17:20:23 +0100 (BST) (envelope-from mark@grondar.org) Received: from grunt.grondar.org (localhost [127.0.0.1]) by grunt.grondar.org (8.13.4/8.13.4) with ESMTP id j7UGI5BK052948 for ; Tue, 30 Aug 2005 17:18:05 +0100 (BST) (envelope-from mark@grunt.grondar.org) Received: (from mark@localhost) by grunt.grondar.org (8.13.4/8.13.4/Submit) id j7UGI5Kp052947; Tue, 30 Aug 2005 17:18:05 +0100 (BST) (envelope-from mark) Message-Id: <200508301618.j7UGI5Kp052947@grunt.grondar.org> Date: Tue, 30 Aug 2005 17:18:05 +0100 (BST) From: Mark Murray To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/85490: [PATCH] If WANT_LINT is set, port building can break X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mark Murray List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2005 16:30:17 -0000 >Number: 85490 >Category: ports >Synopsis: [PATCH] If WANT_LINT is set, port building can break >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Aug 30 16:30:15 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Mark Murray >Release: FreeBSD 6.0-BETA3 i386 >Organization: GTA >Environment: System: FreeBSD grunt.grondar.org 6.0-BETA3 FreeBSD 6.0-BETA3 #1: Mon Aug 29 20:50:36 BST 2005 root@grunt.grondar.org:/usr/src/sys/i386/compile/G_X86_32 i386 All ports that build libraries using the BSD bsd.lib.mk macro sets. >Description: If WANT_LINT is set in /etc/make.conf, then ports that use the /usr/share/mk/bsd.lib.mk macros to make libraries will also try to lint the code, and will fail when no place is found to install the lint library. Linting ports is of no use to the FreeBSD Project, as it only generates output that would be of use to the code author. Linting needs to be turned off summarily for all port work, and the NO_LINT macro is intended for this purpose (also for src/contrib code). >How-To-Repeat: Build a port which uses the bsd.lib.mk, while WANT_LINT is turned on in /etc/make.conf. Example ports/graphics/png >Fix: Index: bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.516 diff -u -d -r1.516 bsd.port.mk --- bsd.port.mk 28 Aug 2005 18:47:56 -0000 1.516 +++ bsd.port.mk 29 Aug 2005 09:52:35 -0000 @@ -1424,7 +1424,7 @@ CONFIGURE_ENV+= SHELL=${SH} CONFIG_SHELL=${SH} PORTOBJFORMAT=${PORTOBJFORMAT} SCRIPTS_ENV+= PORTOBJFORMAT=${PORTOBJFORMAT} -MAKE_ENV+= SHELL=${SH} PORTOBJFORMAT=${PORTOBJFORMAT} +MAKE_ENV+= SHELL=${SH} PORTOBJFORMAT=${PORTOBJFORMAT} NO_LINT=YES PLIST_SUB+= PORTOBJFORMAT=${PORTOBJFORMAT} .if defined(MANCOMPRESSED) >Release-Note: >Audit-Trail: >Unformatted: