Date: Wed, 16 Jan 2002 17:03:57 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Alfred Perlstein <alfred@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sys_generic.c Message-ID: <XFMail.020116170357.jhb@FreeBSD.org> In-Reply-To: <20020116162418.P26067@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17-Jan-02 Alfred Perlstein wrote: > * John Baldwin <jhb@FreeBSD.org> [020116 16:01] wrote: >> >> On 16-Jan-02 Alfred Perlstein wrote: >> > alfred 2002/01/16 13:33:41 PST >> > >> > Modified files: >> > sys/kern sys_generic.c >> > Log: >> > Fix giant handling in pwrite(2), I forgot to release it when finishing >> > the syscall. >> >> Uh, this isn't correct. fdrop() can call fo_close() can call down into VFS >> and do a vrele(), so fdrop() still needs Giant. If you aren't holding Giant >> across fdrop() in a few places that might explain the vput(0x0) panics. > > Ugh, I'll get to this tonight unless you want to tackle it now. No, I'm moving across the country for the next week or so starting tomorrow and wouldn't have time to do it much less test it. > -Alfred -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.020116170357.jhb>