From owner-freebsd-bugs@FreeBSD.ORG Mon Aug 1 12:10:06 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 10E191065670 for ; Mon, 1 Aug 2011 12:10:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C637E8FC0C for ; Mon, 1 Aug 2011 12:10:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p71CA5Tp074529 for ; Mon, 1 Aug 2011 12:10:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p71CA5AB074528; Mon, 1 Aug 2011 12:10:05 GMT (envelope-from gnats) Resent-Date: Mon, 1 Aug 2011 12:10:05 GMT Resent-Message-Id: <201108011210.p71CA5AB074528@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Svatopluk Kraus Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8FDD1065774 for ; Mon, 1 Aug 2011 12:00:27 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id C972B8FC1F for ; Mon, 1 Aug 2011 12:00:27 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p71C0RXx075177 for ; Mon, 1 Aug 2011 12:00:27 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p71C0RTS075176; Mon, 1 Aug 2011 12:00:27 GMT (envelope-from nobody) Message-Id: <201108011200.p71C0RTS075176@red.freebsd.org> Date: Mon, 1 Aug 2011 12:00:27 GMT From: Svatopluk Kraus To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/159351: [patch] - divide by zero in mountnfs() X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2011 12:10:06 -0000 >Number: 159351 >Category: kern >Synopsis: [patch] - divide by zero in mountnfs() >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Aug 01 12:10:05 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Svatopluk Kraus >Release: current >Organization: >Environment: >Description: When nm_wcommitsize is initializing and desiredvnodes is less than 1000 a divide by zero happens. >How-To-Repeat: >Fix: Index: sys/fs/nfsclient/nfs_clvfsops.c =================================================================== --- sys/fs/nfsclient/nfs_clvfsops.c (revision 224571) +++ sys/fs/nfsclient/nfs_clvfsops.c (working copy) @@ -1238,7 +1238,7 @@ nmp->nm_rsize = NFS_RSIZE; nmp->nm_readdirsize = NFS_READDIRSIZE; } - nmp->nm_wcommitsize = hibufspace / (desiredvnodes / 1000); + nmp->nm_wcommitsize = hibufspace / (desiredvnodes / 1000 + 1); nmp->nm_numgrps = NFS_MAXGRPS; nmp->nm_readahead = NFS_DEFRAHEAD; nmp->nm_tprintf_delay = nfs_tprintf_delay; Index: sys/nfsclient/nfs_vfsops.c =================================================================== --- sys/nfsclient/nfs_vfsops.c (revision 224571) +++ sys/nfsclient/nfs_vfsops.c (working copy) @@ -1244,7 +1244,7 @@ nmp->nm_wsize = NFS_WSIZE; nmp->nm_rsize = NFS_RSIZE; } - nmp->nm_wcommitsize = hibufspace / (desiredvnodes / 1000); + nmp->nm_wcommitsize = hibufspace / (desiredvnodes / 1000 + 1); nmp->nm_readdirsize = NFS_READDIRSIZE; nmp->nm_numgrps = NFS_MAXGRPS; nmp->nm_readahead = NFS_DEFRAHEAD; >Release-Note: >Audit-Trail: >Unformatted: