From owner-freebsd-ports@FreeBSD.ORG Tue Oct 5 20:55:13 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 25DC316A4CE for ; Tue, 5 Oct 2004 20:55:13 +0000 (GMT) Received: from mail.mcneil.com (mcneil.com [24.199.45.54]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBE6043D4C for ; Tue, 5 Oct 2004 20:55:12 +0000 (GMT) (envelope-from sean@mcneil.com) Received: from localhost (localhost.mcneil.com [127.0.0.1]) by mail.mcneil.com (Postfix) with ESMTP id C36B2F1AF8; Tue, 5 Oct 2004 13:55:10 -0700 (PDT) Received: from mail.mcneil.com ([127.0.0.1]) by localhost (server.mcneil.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 35552-06; Tue, 5 Oct 2004 13:55:10 -0700 (PDT) Received: from [24.199.45.54] (mcneil.com [24.199.45.54]) by mail.mcneil.com (Postfix) with ESMTP id 22CF5F18E0; Tue, 5 Oct 2004 13:55:10 -0700 (PDT) From: Sean McNeil To: freebsd-ports@freebsd.org Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-HBxLnQY4Bn7/Blh0qHP2" Message-Id: <1097009709.59818.3.camel@server> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Tue, 05 Oct 2004 13:55:10 -0700 X-Virus-Scanned: by amavisd-new at mcneil.com X-Content-Filtered-By: Mailman/MimeDel 2.1.1 cc: ahze@ahze.net Subject: faad port and patches needed to build on -current X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2004 20:55:13 -0000 --=-HBxLnQY4Bn7/Blh0qHP2 Content-Type: multipart/mixed; boundary="=-7j0WaecjBHxfWcoc9Ahd" --=-7j0WaecjBHxfWcoc9Ahd Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I recently tried to build faad and couldn't because there are some virtual functions defined and set to NULL instead of 0. The following 2 patches allowed me to compile (included as text and attached): files/patch-mp4property.h: *** common/mp4v2/mp4property.h.orig Tue Oct 5 13:41:26 2004 --- common/mp4v2/mp4property.h Tue Oct 5 13:42:25 2004 *************** public: *** 58,64 **** return m_name; } =20 ! virtual MP4PropertyType GetType() =3D NULL;=20 =20 bool IsReadOnly() { return m_readOnly; --- 58,64 ---- return m_name; } =20 ! virtual MP4PropertyType GetType() =3D 0;=20 =20 bool IsReadOnly() { return m_readOnly; *************** public: *** 74,90 **** m_implicit =3D value; } =20 ! virtual u_int32_t GetCount() =3D NULL; ! virtual void SetCount(u_int32_t count) =3D NULL; =20 virtual void Generate() { /* default is a no-op */ }; =20 ! virtual void Read(MP4File* pFile, u_int32_t index =3D 0) =3D NULL; =20 ! virtual void Write(MP4File* pFile, u_int32_t index =3D 0) =3D NULL; =20 virtual void Dump(FILE* pFile, u_int8_t indent, ! bool dumpImplicits, u_int32_t index =3D 0) =3D NULL; =20 virtual bool FindProperty(const char* name, MP4Property** ppProperty, u_int32_t* pIndex =3D NULL); --- 74,90 ---- m_implicit =3D value; } =20 ! virtual u_int32_t GetCount() =3D 0; ! virtual void SetCount(u_int32_t count) =3D 0; =20 virtual void Generate() { /* default is a no-op */ }; =20 ! virtual void Read(MP4File* pFile, u_int32_t index =3D 0) =3D 0; =20 ! virtual void Write(MP4File* pFile, u_int32_t index =3D 0) =3D 0; =20 virtual void Dump(FILE* pFile, u_int8_t indent, ! bool dumpImplicits, u_int32_t index =3D 0) =3D 0; =20 virtual bool FindProperty(const char* name, MP4Property** ppProperty, u_int32_t* pIndex =3D NULL); files/patch-rtphint.h: *** common/mp4v2/rtphint.h.orig Tue Oct 5 13:46:32 2004 --- common/mp4v2/rtphint.h Tue Oct 5 13:46:49 2004 *************** public: *** 35,42 **** return m_pPacket; } =20 ! virtual u_int16_t GetDataSize() =3D NULL; ! virtual void GetData(u_int8_t* pDest) =3D NULL; =20 MP4Track* FindTrackFromRefIndex(u_int8_t refIndex); =20 --- 35,42 ---- return m_pPacket; } =20 ! virtual u_int16_t GetDataSize() =3D 0; ! virtual void GetData(u_int8_t* pDest) =3D 0; =20 MP4Track* FindTrackFromRefIndex(u_int8_t refIndex); =20 --=-7j0WaecjBHxfWcoc9Ahd-- --=-HBxLnQY4Bn7/Blh0qHP2 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBYwotyQsGN30uGE4RAmSvAJ4ke9G+6ssV8kjFyanXO9722yCRxgCghxUM QQ8J6vy4os0K01GK9mQBjLo= =pgnN -----END PGP SIGNATURE----- --=-HBxLnQY4Bn7/Blh0qHP2--