From owner-freebsd-ports Wed Feb 20 8:43:32 2002 Delivered-To: freebsd-ports@freebsd.org Received: from shale.csir.co.za (shale.csir.co.za [146.64.46.5]) by hub.freebsd.org (Postfix) with ESMTP id E542237B417 for ; Wed, 20 Feb 2002 08:43:24 -0800 (PST) Received: (from reg@localhost) by shale.csir.co.za (8.11.6/8.11.6) id g1KGh5d36420; Wed, 20 Feb 2002 18:43:05 +0200 (SAT) (envelope-from reg) Date: Wed, 20 Feb 2002 18:43:05 +0200 From: Jeremy Lea To: Matt Sykes Cc: ports@FreeBSD.ORG Subject: Re: variables not passed to sub-makes Message-ID: <20020220184305.C32014@shale.csir.co.za> References: <20020220111945.A32014@shale.csir.co.za> <20020220162201.48559.qmail@web21003.mail.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020220162201.48559.qmail@web21003.mail.yahoo.com>; from mattmsykes@yahoo.co.uk on Wed, Feb 20, 2002 at 04:22:01PM +0000 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi, On Wed, Feb 20, 2002 at 04:22:01PM +0000, Matt Sykes wrote: > But what's with people submitting followups saying it's not > a problem then closing the PR! Glad to see you reopened it > today. > > I counted 155 ports which use CFLAGS+=... in their Makefile, > so some or all of these ports are silently broken. This seems > Pretty Important to me. The problem isn't seen in ports which use configure scripts, gmake or sed/perl methods of getting CFLAGS into the build. People test with this... I've never found the time to solve this. The solution needs to involve preventing the system .mk files (including make.conf) from setting variables which are already set and in use by bsd.port.mk. My simplest idea was to set a PORT_BUILDING variable and avoid including make.conf and (now) bsd.cpu.mk at the end of sys.mk. I really appreciate if you could find a fix for this. Regards, -Jeremy -- FreeBSD - Because the best things in life are free... http://www.freebsd.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message