Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Jan 2001 18:11:50 -0000 (GMT)
From:      Duncan Barclay <dmlb@dmlb.org>
To:        Warner Losh <imp@harmony.village.org>
Cc:        mobile@FreeBSD.ORG, onoe@FreeBSD.ORG
Subject:   Re: memory mapped io for Aironet driver.
Message-ID:  <XFMail.010110181150.dmlb@computer.my.domain>
In-Reply-To: <200101101756.f0AHuXs63066@harmony.village.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi

On 10-Jan-01 Warner Losh wrote:
> In message <XFMail.010110083625.dmlb@computer.my.domain> Duncan Barclay
> writes:
>: Sorry this is for the awi driver not aironet.
> 
> Does this have any impact on performance?  I use awi all the time.

A quick look at awi/am79c930.c says yes:

        static void io_read_bytes (sc, off, ptr, len)
        struct am79c930_softc *sc;
        u_int32_t off;
        u_int8_t *ptr;
        size_t len;
{
        int i;
        
        bus_space_write_1(sc->sc_iot, sc->sc_ioh, AM79C930_LMA_HI,
            ((off>>8)& 0x7f));
        AM930_DELAY(1);
        bus_space_write_1(sc->sc_iot, sc->sc_ioh, AM79C930_LMA_LO, (off&0xff));
        AM930_DELAY(1);
        for (i=0; i<len; i++) 
                ptr[i] = bus_space_read_1(sc->sc_iot, sc->sc_ioh,
                    AM79C930_IODPA);
}

verses

static void mem_read_bytes (sc, off, ptr, len)
        struct am79c930_softc *sc;
        u_int32_t off;
        u_int8_t *ptr;
        size_t len;
{
        bus_space_read_region_1 (sc->sc_memt, sc->sc_memh, off, ptr, len);
}

> Warner

Duncan


---
________________________________________________________________________
Duncan Barclay  | God smiles upon the little children,
dmlb@dmlb.org   | the alcoholics, and the permanently stoned.
dmlb@freebsd.org| Steven King


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010110181150.dmlb>