Date: Tue, 15 Aug 2006 11:30:16 -0400 From: John Baldwin <jhb@freebsd.org> To: Roman Divacky <rdivacky@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 104043 for review Message-ID: <200608151130.17341.jhb@freebsd.org> In-Reply-To: <200608151523.k7FFN7rN002736@repoman.freebsd.org> References: <200608151523.k7FFN7rN002736@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 15 August 2006 11:23, Roman Divacky wrote: > http://perforce.freebsd.org/chv.cgi?CH=104043 > > Change 104043 by rdivacky@rdivacky_witten on 2006/08/15 15:22:57 > > Grrrr. Do the locking/unlocking correctly this time. > > Affected files ... > > .. //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#27 edit > > Differences ... > > ==== //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#27 (text+ko) ==== > > @@ -339,9 +339,13 @@ > return f; > } > } > + if (locked == FUTEX_UNLOCKED) > + FUTEX_UNLOCK; > > /* Not found, create it */ > f = malloc(sizeof(*f), M_LINUX, M_WAITOK); > + if (locked == FUTEX_UNLOCKED) > + FUTEX_LOCK; > f->f_uaddr = uaddr; > f->f_refcount = 1; > TAILQ_INIT(&f->f_waiting_proc); This readds the race. :) See my other e-mail on what you have to do to handle it. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608151130.17341.jhb>