Date: Wed, 18 Nov 2009 12:06:12 -0800 From: Artem Belevich <fbsdlist@src.cx> To: Norikatsu Shigemura <nork@freebsd.org>, Alexander Motin <mav@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: How do I use NCQ of Intel X25-E(SSD) on ahci(4)? Message-ID: <ed91d4a80911181206s65a555c4q82f650283c5ac1e8@mail.gmail.com> In-Reply-To: <20091119021440.560884b2.nork@FreeBSD.org> References: <20091119004651.7432a6e4.nork@FreeBSD.org> <4B042304.8060807@FreeBSD.org> <20091119021440.560884b2.nork@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> --- sys/dev/ahci/ahci.c.orig =A0 =A02009-11-17 22:25:07.474418000 +0900 > +++ sys/dev/ahci/ahci.c 2009-11-19 02:00:22.193688908 +0900 > @@ -779,7 +779,7 @@ > =A0 =A0 =A0 =A0ch->caps =3D ctlr->caps; > =A0 =A0 =A0 =A0ch->caps2 =3D ctlr->caps2; > =A0 =A0 =A0 =A0ch->quirks =3D ctlr->quirks; > - =A0 =A0 =A0 ch->numslots =3D ((ch->caps & AHCI_CAP_NCS) >> AHCI_CAP_NCS= _SHIFT) + 1, > + =A0 =A0 =A0 ch->numslots =3D min(31, ((ch->caps & AHCI_CAP_NCS) >> AHCI= _CAP_NCS_SHIFT) + 1), > =A0 =A0 =A0 =A0mtx_init(&ch->mtx, "AHCI channel lock", NULL, MTX_DEF); > =A0 =A0 =A0 =A0resource_int_value(device_get_name(dev), > =A0 =A0 =A0 =A0 =A0 =A0device_get_unit(dev), "pm_level", &ch->pm_level); The comma at the end of the "ch->numslots =3D ..." line looks suspicious. Shouldn't it be ';' ? --Artem
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ed91d4a80911181206s65a555c4q82f650283c5ac1e8>