From owner-cvs-usrbin Mon Jul 14 07:32:36 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id HAA24079 for cvs-usrbin-outgoing; Mon, 14 Jul 1997 07:32:36 -0700 (PDT) Received: from spinner.dialix.com.au (spinner.dialix.com.au [192.203.228.67]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id HAA24074; Mon, 14 Jul 1997 07:32:22 -0700 (PDT) Received: from spinner.dialix.com.au (localhost.dialix.com.au [127.0.0.1]) by spinner.dialix.com.au with ESMTP id WAA05038; Mon, 14 Jul 1997 22:31:53 +0800 (WST) Message-Id: <199707141431.WAA05038@spinner.dialix.com.au> X-Mailer: exmh version 2.0delta 6/3/97 To: Adam David cc: peter@FreeBSD.ORG (Peter Wemm), cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrbin@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/top machine.c In-reply-to: Your message of "Mon, 14 Jul 1997 10:50:44 GMT." <199707141050.KAA21385@ubiq.veda.is> Date: Mon, 14 Jul 1997 22:31:52 +0800 From: Peter Wemm Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Adam David wrote: > > peter 1997/07/14 02:06:47 PDT > > > > Modified files: > > usr.bin/top machine.c > > Log: > > Hack to work around the large username field... scan for the largest > > username present on the system at startup and use that for the field widt h. > > It's not ideal but (I think) better than it was before. The width is > > limited to within 8..16. > > > > Revision Changes Path > > 1.5 +25 -19 src/usr.bin/top/machine.c > > Wasn't it a better idea to keep track of username length for the processes th at > top sees? And what if somebody with a 16 character login name logs in? You can't take a snapshot of what is currently visible and assume that no new uid's are going to turn up... I had considered trying to expand the column on demand when/if a username longer than 8 characters logs in. Would that make sense? I don't think it's too hard but it will require more tweaks inside src/contrib/top. > -- > Adam David > Cheers, -Peter