From owner-freebsd-questions@FreeBSD.ORG Mon Feb 16 04:37:27 2009 Return-Path: Delivered-To: freebsd-questions@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD380106566C for ; Mon, 16 Feb 2009 04:37:27 +0000 (UTC) (envelope-from list@museum.rain.com) Received: from ns.umpquanet.com (ns.umpquanet.com [204.119.0.16]) by mx1.freebsd.org (Postfix) with ESMTP id 75DED8FC0C for ; Mon, 16 Feb 2009 04:37:27 +0000 (UTC) (envelope-from list@museum.rain.com) Received: from ns.umpquanet.com (localhost [127.0.0.1]) by ns.umpquanet.com (8.14.2/8.14.2) with ESMTP id n1G49MIi009070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 15 Feb 2009 20:09:22 -0800 (PST) (envelope-from list@museum.rain.com) Received: (from james@localhost) by ns.umpquanet.com (8.14.2/8.14.2/Submit) id n1G49MAH009069 for freebsd-questions@freebsd.org; Sun, 15 Feb 2009 20:09:22 -0800 (PST) (envelope-from list@museum.rain.com) Date: Sun, 15 Feb 2009 20:09:22 -0800 From: James Long To: freebsd-questions@freebsd.org Message-ID: <20090216040922.GA6157@ns.umpquanet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Subject: Makefile error in lang/perl5.8? X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2009 04:37:27 -0000 I'm attempting to: portupgrade -p perl-threaded-5.8.9 My ports tree is updated to the 5.8.9_1 revision: # New ports collection makefile for: perl5 # Date created: 16 April 1995 # Whom: markm # # $FreeBSD: ports/lang/perl5.8/Makefile,v 1.100 2009/02/15 22:42:37 skv Exp $ # PORTNAME= perl PORTVERSION= ${PERL_VER} PORTREVISION= 1 CATEGORIES= lang devel perl5 MASTER_SITES= CPAN \ ${MASTER_SITE_LOCAL:S/$/:local/} \ http://protey.ru/freebsd/distfiles/:local MASTER_SITE_SUBDIR= ../../src \ skv/:local DISTFILES= ${DISTNAME}${EXTRACT_SUFX} \ BSDPAN-${BSDPAN_VERSION}${EXTRACT_SUFX}:local DIST_SUBDIR= perl ... portupgrade fails with: /bin/mkdir -p /usr/local/lib/perl5/5.8.9/BSDPAN/. install -o root -g wheel -m 444 /usr/ports/lang/perl5.8/work/BSDPAN-5.8.9/BSDPAN.pm /usr/local/lib/perl5/5.8.9/BSDPAN/BSDPAN.pm install: /usr/ports/lang/perl5.8/work/BSDPAN-5.8.9/BSDPAN.pm: No such file or directory *** Error code 71 Stop in /usr/ports/lang/perl5.8. *** Error code 1 Stop in /usr/ports/lang/perl5.8. *** Error code 1 Stop in /usr/ports/lang/perl5.8. ** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portupgrade20090215-43761-1d44k1l-0 env UPGRADE_TOOL=portupgrade UPGRADE_PORT=perl-threaded-5.8.9 UPGRADE_PORT_VER=5.8.9 make WITH_THREADS=1 DEPENDS_TARGET=package reinstall ---> Restoring the old version ... The actual location of BSDPAN.pm is: $ locate BSDPAN.pm /usr/ports/lang/perl5.8/work/BSDPAN-5.8.9_1/BSDPAN.pm My presumption is that the Makefile's install path of /usr/ports/lang/perl5.8/work/BSDPAN-5.8.9/BSDPAN.pm is erronous in not including the "_1" PORTREVISION value after the 5.8.9 in "BSDPAN-5.8.9". I applied the diff below to the Makefile, and 'portupgrade -wp perl-threaded-5.8.9' completed successfully. Is this the correct fix? I realize the better fix might be to include "_${PORTREVISION}" instead of the literal "_1", but since the BSDPAN_VERSION line did it that way, I copied. If not correct, can someone please educate me how I might fix this properly? If it is correct, can someone please update the Makefile? Thanks, Jim # diff -u Makefile.orig Makefile --- Makefile.orig 2009-02-15 19:57:19.000000000 -0800 +++ Makefile 2009-02-15 19:58:31.000000000 -0800 @@ -143,7 +143,7 @@ ExtUtils/MakeMaker.pm \ ExtUtils/Packlist.pm BSDPAN_VERSION= ${PORTVERSION}_1 -BSDPAN_WRKSRC= ${WRKDIR}/BSDPAN-${PORTVERSION} +BSDPAN_WRKSRC= ${WRKDIR}/BSDPAN-${PORTVERSION}_1 PKGINSTALL= ${WRKDIR}/pkg-install PKGDEINSTALL= ${WRKDIR}/pkg-deinstall