From owner-freebsd-ports Fri May 19 8:40:10 2000 Delivered-To: freebsd-ports@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 84C4F37BEF3 for ; Fri, 19 May 2000 08:40:08 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id IAA78719; Fri, 19 May 2000 08:40:08 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Date: Fri, 19 May 2000 08:40:08 -0700 (PDT) Message-Id: <200005191540.IAA78719@freefall.freebsd.org> To: freebsd-ports@FreeBSD.org Cc: From: mi@privatelabs.com Subject: Re: ports/18659: devel/libol port ignores CC/CFLAGS for some files Reply-To: mi@privatelabs.com Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR ports/18659; it has been noted by GNATS. From: mi@privatelabs.com To: Vince Valenti Cc: Will Andrews , mi@aldan.algebra.com, FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/18659: devel/libol port ignores CC/CFLAGS for some files Date: Fri, 19 May 2000 11:39:22 -0400 (EDT) On 18 May, Vince Valenti wrote: = On Thu, 18 May 2000, Will Andrews wrote: = = > On Thu, May 18, 2000 at 05:30:01PM -0700, Will Andrews wrote: = > > + CFLAGS="${CFLAGS} -Wall $LIBOL_CFLAGS -D_GNU_SOURCE" = > = > Actually, doesn't this sort of thing result in make(1) spewing = > something like "recursive variable CFLAGS" or similar? This may not = > be the best way to implement enforced CFLAGS. You probably should = > have something like ${PCFLAGS} here instead, and define PCFLAGS= = > ${CFLAGS} in the port Makefile. = = It seemed to work when I ran the suggested patch... I'd say go ahead = and commit it. If it would be better to have a PCFLAGS variable, I can = whip up a patch for that if you'd like. The same problem exists for the devel/libol (see ports/18659). That software comes from the author, with the same bug in the configure. Please, consider the same patch (line numbers may be different) :) -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message