From owner-cvs-all@FreeBSD.ORG Tue Jun 7 13:51:46 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 622F916A41C; Tue, 7 Jun 2005 13:51:46 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29B8243D55; Tue, 7 Jun 2005 13:51:46 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 1D3195CA7D; Tue, 7 Jun 2005 06:51:46 -0700 (PDT) Date: Tue, 7 Jun 2005 06:51:46 -0700 From: Alfred Perlstein To: John-Mark Gurney Message-ID: <20050607135146.GI17867@elvis.mu.org> References: <200506070635.j576ZAgo066489@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200506070635.j576ZAgo066489@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_event.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2005 13:51:46 -0000 * John-Mark Gurney [050606 23:35] wrote: > jmg 2005-06-07 06:35:10 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_5) > sys/kern kern_event.c > Log: > MFC: v1.91 > make stat return an zero'd struct, and be a FIFO again... This is only > to fix libc_r since it requires stat to close fd's, and so commented in > the code... I'd like to request that you restore the st_size return value. Or maybe explain that the number of events can be queried via some alternate means. The kqueue manpage does not seem to explicitly state how to just poll the number of pending events. There are plenty of userland/kernel races and it's ok to have them. Maybe just fix the manpage? But removing the functionality behind stat will surely break apps that depended on it. -- - Alfred Perlstein - email: bright@mu.org cell: 408-480-4684