From owner-freebsd-current@FreeBSD.ORG Sat Jan 11 12:52:34 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 61FF0F39 for ; Sat, 11 Jan 2014 12:52:34 +0000 (UTC) Received: from mail.acc.umu.se (mail.acc.umu.se [IPv6:2001:6b0:e:2018::156]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DC5C81118 for ; Sat, 11 Jan 2014 12:52:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by amavisd-new (Postfix) with ESMTP id 0FE9BE86; Sat, 11 Jan 2014 13:52:32 +0100 (MET) X-Virus-Scanned: amavisd-new at acc.umu.se Received: from shaka.acc.umu.se (shaka.acc.umu.se [IPv6:2001:6b0:e:2018::148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: mk) by mail.acc.umu.se (Postfix) with ESMTPSA id 3A8C6E85; Sat, 11 Jan 2014 13:52:31 +0100 (MET) Date: Sat, 11 Jan 2014 13:52:29 +0100 From: Marcus Karlsson To: "O. Hartmann" Subject: Re: CURRENT: build world failure: /usr/src/usr.sbin/bhyvectl/bhyvectl.c:1466:8: error: use of undeclared identifier 'VMCS_EXIT_INTERRUPTION_ERROR' VMCS_EXIT_INTERRUPTION_ERROR, &u64); Message-ID: <20140111125229.GG2390@shaka.acc.umu.se> References: <20140111113206.581760d9@thor.walstatt.dyndns.org> <20140111113444.GF2390@shaka.acc.umu.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="SNIs70sCzqvszXB4" Content-Disposition: inline In-Reply-To: <20140111113444.GF2390@shaka.acc.umu.se> Organization: Academic Computer Club =?iso-8859-1?Q?Ume?= =?iso-8859-1?Q?=E5?= University User-Agent: Mutt/1.5.22 (2013-10-16) Cc: FreeBSD CURRENT X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jan 2014 12:52:34 -0000 --SNIs70sCzqvszXB4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jan 11, 2014 at 12:34:44PM +0100, Marcus Karlsson wrote: > On Sat, Jan 11, 2014 at 11:32:06AM +0100, O. Hartmann wrote: > > Recent sources (revision 260540) fail to build: > > > > cc -O2 -pipe -O3 -march=native > > -I/usr/src/usr.sbin/bhyvectl/../../sys/amd64/vmm -pipe -O3 -std=gnu99 > > -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall > > -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes > > -Wmissing-prototypes -Wpointer-arith -Wno-uninitialized > > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int > > -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality > > -Wno-unused-function -Wno-enum-conversion > > -c /usr/src/usr.sbin/bhyvectl/bhyvectl.c /usr/src/usr.sbin/bhyvectl/bhyvectl.c:1457:8: > > error: use of undeclared identifier 'VMCS_EXIT_INTERRUPTION_INFO'; did > > you mean 'SET_VMCS_ENTRY_INTERRUPTION_INFO'? > > VMCS_EXIT_INTERRUPTION_INFO, &u64); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > SET_VMCS_ENTRY_INTERRUPTION_INFO /usr/src/usr.sbin/bhyvectl/bhyvectl.c:382:2: > > note: 'SET_VMCS_ENTRY_INTERRUPTION_INFO' declared here > > SET_VMCS_ENTRY_INTERRUPTION_INFO, > > ^ /usr/src/usr.sbin/bhyvectl/bhyvectl.c:1466:8: error: use of > > undeclared identifier 'VMCS_EXIT_INTERRUPTION_ERROR' > > VMCS_EXIT_INTERRUPTION_ERROR, &u64); > > I see the same thing. It appears that the definition of > VMCS_EXIT_INTERRUPTION_INFO and VMCS_EXIT_INTERRUPTION_ERROR changed in > r260531 to VMC_EXIT_INT_INFO and VMCS_EXIT_INTR_ERRCODE respectively. This patch was enough for the build to complete successfully in case anyone else wants it. The old macros are not used anywhere else in the source tree apart from bhyvectl. --SNIs70sCzqvszXB4 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="bhyvectl.patch" Index: usr.sbin/bhyvectl/bhyvectl.c =================================================================== --- usr.sbin/bhyvectl/bhyvectl.c (revision 260540) +++ usr.sbin/bhyvectl/bhyvectl.c (working copy) @@ -1454,7 +1454,7 @@ if (!error && (get_vmcs_exit_interruption_info || get_all)) { error = vm_get_vmcs_field(ctx, vcpu, - VMCS_EXIT_INTERRUPTION_INFO, &u64); + VMCS_EXIT_INTR_INFO, &u64); if (error == 0) { printf("vmcs_exit_interruption_info[%d]\t0x%08lx\n", vcpu, u64); @@ -1463,7 +1463,7 @@ if (!error && (get_vmcs_exit_interruption_error || get_all)) { error = vm_get_vmcs_field(ctx, vcpu, - VMCS_EXIT_INTERRUPTION_ERROR, &u64); + VMCS_EXIT_INTR_ERRCODE, &u64); if (error == 0) { printf("vmcs_exit_interruption_error[%d]\t0x%08lx\n", vcpu, u64); --SNIs70sCzqvszXB4--