From owner-freebsd-arch@freebsd.org Wed Aug 7 20:50:08 2019 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 675D1B76A5 for ; Wed, 7 Aug 2019 20:50:08 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 463kCg3vFKz4KKD for ; Wed, 7 Aug 2019 20:50:07 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x77Ko5AH089299; Wed, 7 Aug 2019 13:50:05 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x77Ko5QD089298; Wed, 7 Aug 2019 13:50:05 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201908072050.x77Ko5QD089298@gndrsh.dnsmgr.net> Subject: Re: svn commit: r350550 - head/share/mk In-Reply-To: <20190807201448.GA42725@bastion.zyxst.net> To: tech-lists Date: Wed, 7 Aug 2019 13:50:05 -0700 (PDT) CC: freebsd-arch@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 463kCg3vFKz4KKD X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Spamd-Result: default: False [0.02 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.29)[-0.289,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.11)[0.106,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.74)[-0.742,0]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.05)[ip: (0.15), ipnet: 69.59.192.0/19(0.08), asn: 13868(0.05), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Aug 2019 20:50:08 -0000 > Hello, > > On Tue, Aug 06, 2019 at 04:56:14PM +0000, Glen Barber wrote: > > >I would like to request this commit be reverted. While the original > >commit message to enable this knob stated the commit would be reverted > >after stable/12 branched, I have seen no public complaints about > >enabling REPRODUCIBLE_BUILD by default (and quite honestly, do not see > >the benefit of disabling it by default -- why wouldn't we want > >reproducibility?). > > > >To me, this feels like a step backwards, with no tangible benefit. > >Note, newvers.sh does properly detect a modified tree if it can find > >the VCS metadata directory (i.e., .git, .svn) -- I know this because > >I personally helped with it. > > > >In my opinion, those that want the non-reproducible metadata included in > >output from 'uname -a' should set WITHOUT_REPRODUCIBLE_BUILDS in their > >src.conf. Turning off a sane default for the benefit of what I suspect > >is likely a short list of use cases feels like a step in the wrong > >direction. > > Well, my use case is that I have some machines that follow 12-stable. > > I'm not a developer. But I keep an eye on things like security bulletins > etc and when they come out it usually gives something like 'affecting > 12-STABLE prior to r something like that. And I can easily look > at uname -a to see if this or that 12-stable machine needs to be patched > or whatever. That is, if reproductible_build is turned off. (or > without_reproductible_build is turned on) > > Or if I mail to stable@ asking for help I'll want to say *exactly* what > sources I've built from. And sometimes someone will say "oh that was > fixed after r" and so I'll grab sources after that revision > if I can and fix the problem. > > But like I say I'm not a dev. I'd guess, though, that lots of non-devs > use the revision info if they follow -stable, so if I'm right in thinking > this, it'd be a short list of use cases but lots of affected people. > > unless there's another way to get the svn rev number? > > Why turn off this functionality by default? > -- > J. Actually you have a very good point here. Let me raise the issue, the rXXXXXX is infact reproducible, why is that being excluded from reproducible builds? If I build from the same source at the same version I get the same rXXXXX string in the resulting file. This is reproducible. So WHY are we excluding rXXXXXX from the reproducible build? -- Rod Grimes rgrimes@freebsd.org