From owner-cvs-all Sun Feb 3 14: 1:13 2002 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 69DB637B404; Sun, 3 Feb 2002 14:01:05 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id C56E25341; Sun, 3 Feb 2002 23:01:03 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Mark Murray Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_lastlog pam_lastlog.c src/lib/libpam/modules/pam_login_access login_access.c pam_login_access.c pam_login_access.h src/lib/libpam/modules/pam_securetty pam_securetty.c src/lib/libpam/modules/pam_unix pam_unix.c References: <200202031517.g13FHwb73258@freefall.freebsd.org> From: Dag-Erling Smorgrav Date: 03 Feb 2002 23:01:03 +0100 In-Reply-To: <200202031517.g13FHwb73258@freefall.freebsd.org> Message-ID: Lines: 31 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Mark Murray writes: > markm 2002/02/03 07:17:57 PST > > Modified files: > lib/libpam/modules/pam_lastlog pam_lastlog.c > lib/libpam/modules/pam_login_access login_access.c > pam_login_access.c > lib/libpam/modules/pam_securetty pam_securetty.c > lib/libpam/modules/pam_unix pam_unix.c > Added files: > lib/libpam/modules/pam_login_access pam_login_access.h > Log: > WARNS=n fixes (and some stylistic issues). You've introduced memory leaks and potential segfaults in pam_unix() (you added strdup()s in several places but you don't check the return value and don't free() them later). Other stuff: - pam_securetty should use _PATH_DEV instead of TTY_PREFIX - some long lines should be split (have to ask bde about that) - commit included non-trivial changes to salt generation which should have been mentioned in log message (others would say they should have been committed separately, but I don't mind) DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message