From owner-freebsd-bugs@FreeBSD.ORG Tue Nov 27 17:50:03 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2600716A46B for ; Tue, 27 Nov 2007 17:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 06A5313C46E for ; Tue, 27 Nov 2007 17:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lARHo2GW019474 for ; Tue, 27 Nov 2007 17:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lARHo242019473; Tue, 27 Nov 2007 17:50:02 GMT (envelope-from gnats) Resent-Date: Tue, 27 Nov 2007 17:50:02 GMT Resent-Message-Id: <200711271750.lARHo242019473@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mykola Zubach Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3955016A417 for ; Tue, 27 Nov 2007 17:49:45 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 28F1713C46E for ; Tue, 27 Nov 2007 17:49:45 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lARHncTS063536 for ; Tue, 27 Nov 2007 17:49:38 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id lARHncZv063535; Tue, 27 Nov 2007 17:49:38 GMT (envelope-from nobody) Message-Id: <200711271749.lARHncZv063535@www.freebsd.org> Date: Tue, 27 Nov 2007 17:49:38 GMT From: Mykola Zubach To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/118286: watch(8) allow use up to 10 snp* devices X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2007 17:50:03 -0000 >Number: 118286 >Category: bin >Synopsis: watch(8) allow use up to 10 snp* devices >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 27 17:50:02 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Mykola Zubach >Release: 6.2-RELEASE-p8 >Organization: AdvancedHosters.com >Environment: FreeBSD advancedhosters.com 6.2-RELEASE-p8 FreeBSD 6.2-RELEASE-p8 #3: Fri Nov 16 12:31:53 UTC 2007 root@advancedhosters.com:/usr/src/sys/i386/compile/Z i386 >Description: for (c = '0'; c <= '9'; c++) { This code is self explanatory watch(8) do up to 10 tries to find not used /dev/snp*, and then fail I've rewrite this part so it could use up to 999 snp devices. >How-To-Repeat: open 11 watch(8) sessions in parallel >Fix: /usr/src/usr.sbin/watch patch < /path/2/patch Patch attached with submission follows: --- watch.c Tue Nov 27 19:44:33 2007 +++ watch.c.new Tue Nov 27 19:45:25 2007 @@ -152,19 +152,18 @@ static int open_snp(void) { - char snp[] = {_PATH_DEV "snpX"}; - char c; - int f, mode, pos; + char snp[] = {_PATH_DEV "snpXXX"}; + int f, mode, pos, c; - pos = strlen(snp) - 1; + pos = strlen(snp) - 3; if (opt_write) mode = O_RDWR; else mode = O_RDONLY; if (opt_snpdev == NULL) - for (c = '0'; c <= '9'; c++) { - snp[pos] = c; + for (c = 0; c <= 999; c++) { + snprintf(snp+pos, 4, "%d", c); if ((f = open(snp, mode)) < 0) { if (errno == EBUSY) continue; >Release-Note: >Audit-Trail: >Unformatted: