From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Oct 13 15:00:17 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D3BD106566B for ; Wed, 13 Oct 2010 15:00:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2A12E8FC18 for ; Wed, 13 Oct 2010 15:00:17 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9DF0H9t046579 for ; Wed, 13 Oct 2010 15:00:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o9DF0GOq046562; Wed, 13 Oct 2010 15:00:17 GMT (envelope-from gnats) Resent-Date: Wed, 13 Oct 2010 15:00:17 GMT Resent-Message-Id: <201010131500.o9DF0GOq046562@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexander Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CCFBE106564A for ; Wed, 13 Oct 2010 14:59:23 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id A0F9C8FC15 for ; Wed, 13 Oct 2010 14:59:23 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o9DExMDr000573 for ; Wed, 13 Oct 2010 14:59:22 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o9DExMM2000572; Wed, 13 Oct 2010 14:59:22 GMT (envelope-from nobody) Message-Id: <201010131459.o9DExMM2000572@www.freebsd.org> Date: Wed, 13 Oct 2010 14:59:22 GMT From: Alexander To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/151430: [patch] net-mgmt/kismet fails to build with plugins X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2010 15:00:17 -0000 >Number: 151430 >Category: ports >Synopsis: [patch] net-mgmt/kismet fails to build with plugins >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Oct 13 15:00:16 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Alexander >Release: 8.1-RELEASE >Organization: >Environment: FreeBSD vbox 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:55:53 UTC 2010 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: First: ----- In Makefile.inc.in: .. PLUGINLDFLAGS = @PLUGINLDFLAGS@ .. In FreeBSD kismet configures with empty @PLUGINLDFLAGS@, so PLUGINLDFLAGS in Makefile.inc has empty value. In plugins Makefiles: .. PLUGINLDFLAGS ?= $(LDFLAGS) .. so, plugin fails to build without any LDFLAGS. I suggest to remove "PLUGINLDFLAGS = @PLUGINLDFLAGS@" from Makefile.inc.in. Second: ----- In /usr/ports/net-mgmt/kismet/Makefile: .. ${REINPLACE_CMD} -e "s/plugin-/plugin-[aps]/" \ .. so, builds only plugin-autowep, plugin-ptw & plugin-spectools, without plugin-btscan. >How-To-Repeat: # cd /usr/ports/net-mgmt/kismet # make config Enable PLUGINS option >Fix: In attached patch. Patch attached with submission follows: diff -U3 /usr/ports/net-mgmt/kismet.orig/Makefile /usr/ports/net-mgmt/kismet/Makefile --- /usr/ports/net-mgmt/kismet.orig/Makefile 2010-10-03 07:42:20.000000000 +0000 +++ /usr/ports/net-mgmt/kismet/Makefile 2010-10-13 14:51:41.000000000 +0000 @@ -80,10 +80,11 @@ -e "/ouifile=/{/wireshark/d;s|/etc|${DOCSDIR}|;}" \ ${WRKSRC}/conf/kismet.conf.in \ ${WRKSRC}/conf/kismet_drone.conf - ${REINPLACE_CMD} -e "s/plugin-/plugin-[aps]/" \ - -e "s/make/${GMAKE}/" \ + ${REINPLACE_CMD} -e "s/make/${GMAKE}/" \ -e "s/\$$(MAKE)/${GMAKE}/" \ ${WRKSRC}/Makefile.in + ${REINPLACE_CMD} -e 's/^PLUGINLDFLAGS[^$$]*//' \ + ${WRKSRC}/Makefile.inc.in post-install: .ifndef(NOPORTDOCS) Common subdirectories: /usr/ports/net-mgmt/kismet.orig/files and /usr/ports/net-mgmt/kismet/files diff -U3 /usr/ports/net-mgmt/kismet.orig/pkg-plist /usr/ports/net-mgmt/kismet/pkg-plist --- /usr/ports/net-mgmt/kismet.orig/pkg-plist 2010-10-03 07:42:20.000000000 +0000 +++ /usr/ports/net-mgmt/kismet/pkg-plist 2010-10-13 14:52:02.000000000 +0000 @@ -9,6 +9,7 @@ etc/kismet_drone.conf.sample %%PLUGINS%%lib/kismet/aircrack-kismet.so %%PLUGINS%%lib/kismet/autowep-kismet.so +%%PLUGINS%%lib/kismet/btscan.so %%PLUGINS%%lib/kismet/spectool_net.so %%PLUGINS%%lib/kismet_client/spectools_ui.so %%DATADIR%%/wav/alert.wav >Release-Note: >Audit-Trail: >Unformatted: