From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Sep 29 04:20:02 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6FC6B106566C for ; Wed, 29 Sep 2010 04:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 30DC68FC12 for ; Wed, 29 Sep 2010 04:20:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o8T4K2eg022028 for ; Wed, 29 Sep 2010 04:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o8T4K2ND022027; Wed, 29 Sep 2010 04:20:02 GMT (envelope-from gnats) Resent-Date: Wed, 29 Sep 2010 04:20:02 GMT Resent-Message-Id: <201009290420.o8T4K2ND022027@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Gerald Pfeifer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DED22106566C for ; Wed, 29 Sep 2010 04:11:41 +0000 (UTC) (envelope-from pfeifer@sputnik1.dbai.tuwien.ac.at) Received: from sputnik1.dbai.tuwien.ac.at (sputnik1.dbai.tuwien.ac.at [128.131.111.141]) by mx1.freebsd.org (Postfix) with ESMTP id 7747D8FC13 for ; Wed, 29 Sep 2010 04:11:40 +0000 (UTC) Received: from sputnik1.dbai.tuwien.ac.at (localhost [127.0.0.1]) by sputnik1.dbai.tuwien.ac.at (8.14.4/8.14.4) with ESMTP id o8T4Bdhj075177; Wed, 29 Sep 2010 06:11:39 +0200 (CEST) (envelope-from pfeifer@sputnik1.dbai.tuwien.ac.at) Received: (from pfeifer@localhost) by sputnik1.dbai.tuwien.ac.at (8.14.4/8.14.4/Submit) id o8T4Bd5d075176; Wed, 29 Sep 2010 06:11:39 +0200 (CEST) (envelope-from pfeifer) Message-Id: <201009290411.o8T4Bd5d075176@sputnik1.dbai.tuwien.ac.at> Date: Wed, 29 Sep 2010 06:11:39 +0200 (CEST) From: Gerald Pfeifer To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/151047: Pass CPP to CONFIGURE_ENV and MAKE_ENV in Mk/bsd.port.mk X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2010 04:20:02 -0000 >Number: 151047 >Category: ports >Synopsis: Pass CPP to CONFIGURE_ENV and MAKE_ENV in Mk/bsd.port.mk >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Sep 29 04:20:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Gerald Pfeifer >Release: >Organization: >Environment: >Description: Right now the Ports Collection machinery passes CC and CXX and their flags as part of CONFIGURE_ENV and MAKE_ENV, alas not CPP which very well may depend on the compiler chosen. And indeed Mk/bsd.gcc.mk now sets CPP properly in the case of USE_GCC. >How-To-Repeat: >Fix: The patch below should address this by adding CPP in both places. To make the two invocations symmetric, the order of variables in the former now matches the one of the latter. Index: bsd.port.mk =================================================================== RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v retrieving revision 1.648 diff -u -3 -p -r1.648 bsd.port.mk --- bsd.port.mk 26 Sep 2010 07:59:13 -0000 1.648 +++ bsd.port.mk 29 Sep 2010 04:07:49 -0000 @@ -2274,7 +2274,8 @@ MAKEFILE?= Makefile MAKE_ENV+= PREFIX=${PREFIX} \ LOCALBASE=${LOCALBASE} X11BASE=${X11BASE} \ MOTIFLIB="${MOTIFLIB}" LIBDIR="${LIBDIR}" \ - CC="${CC}" CFLAGS="${CFLAGS}" CXX="${CXX}" CXXFLAGS="${CXXFLAGS}" \ + CC="${CC}" CPP="${CPP}" CXX="${CXX}" \ + CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}" \ MANPREFIX="${MANPREFIX}" # Add -fno-strict-aliasing to CFLAGS with optimization level -O2 or higher. @@ -3776,7 +3777,7 @@ do-configure: .if defined(HAS_CONFIGURE) @(cd ${CONFIGURE_WRKSRC} && \ ${SET_LATE_CONFIGURE_ARGS} \ - if ! ${SETENV} CC="${CC}" CXX="${CXX}" \ + if ! ${SETENV} CC="${CC}" CPP="${CPP}" CXX="${CXX}" \ CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}" \ INSTALL="/usr/bin/install -c ${_BINOWNGRP}" \ INSTALL_DATA="${INSTALL_DATA}" \ >Release-Note: >Audit-Trail: >Unformatted: