From owner-cvs-all  Tue Jan  1  1:29:15 2002
Delivered-To: cvs-all@freebsd.org
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6746537B41B; Tue,  1 Jan 2002 01:29:09 -0800 (PST)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.11.6/8.11.6) with ESMTP id g019QiV69093;
	Tue, 1 Jan 2002 10:26:52 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Marcel Moolenaar <marcel@xcllnt.net>
Cc: Julian Elischer <julian@elischer.org>,
	John Baldwin <jhb@FreeBSD.org>, cvs-all@FreeBSD.org,
	cvs-committers@FreeBSD.org, Julian Elischer <julian@FreeBSD.org>,
	Greg Lehey <grog@FreeBSD.org>
Subject: Re: cvs commit: src/share/man/man3 queue.3 
In-Reply-To: Your message of "Mon, 31 Dec 2001 19:01:26 PST."
             <20011231190126.A755@dhcp01.pn.xcllnt.net> 
Date: Tue, 01 Jan 2002 10:26:44 +0100
Message-ID: <69091.1009877204@critter.freebsd.dk>
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In message <20011231190126.A755@dhcp01.pn.xcllnt.net>, Marcel Moolenaar writes:

>What's wrong with the following if _FOREACH is preferred:
>
>	TAILQ_FOREACH(p, &list, p_next) {
>		if (some_test_on(p)) {
>			/* Do something */
>			break; /* optional */
>		}
>	}

I think this is far superior to the TAILQ_UNTIL idea.

We don't want to add too many obscure variants to queue(3).

"KISS shall prevail" remember ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message