From owner-freebsd-doc@FreeBSD.ORG Wed Nov 28 17:00:01 2012 Return-Path: Delivered-To: freebsd-doc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6240F9CA for ; Wed, 28 Nov 2012 17:00:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 2EDE38FC15 for ; Wed, 28 Nov 2012 17:00:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qASH010p049585 for ; Wed, 28 Nov 2012 17:00:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qASH00SE049581; Wed, 28 Nov 2012 17:00:00 GMT (envelope-from gnats) Date: Wed, 28 Nov 2012 17:00:00 GMT Message-Id: <201211281700.qASH00SE049581@freefall.freebsd.org> To: freebsd-doc@FreeBSD.org Cc: From: Eitan Adler Subject: Re: docs/173971: fdp-primer quick start section makes reference to 'make lint' X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Eitan Adler List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2012 17:00:01 -0000 The following reply was made to PR docs/173971; it has been noted by GNATS. From: Eitan Adler To: Derek Wood , Hiroki Sato Cc: bug-followup@freebsd.org Subject: Re: docs/173971: fdp-primer quick start section makes reference to 'make lint' Date: Wed, 28 Nov 2012 11:59:13 -0500 [ccing hrs as he is the one whom added the target in the first place] On 28 November 2012 10:40, Derek Wood wrote: > As per eadler@, 'make lint' in the FreeBSD document tree is broken, and the reference to it in the fdp-primer book ( http://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/overview-quick-start.html ) is erroneous. >>How-To-Repeat: My understanding is that the "make lint" target is currently broken and non-useful. If I am wrong and this target is intended to work please let me know. This patch removes the target and text explaining it. commit 2e984ecbace3df739ecf147c76fcd6d2645c33cb Author: Eitan Adler Date: Wed Nov 28 11:57:26 2012 -0500 Remove 'lint' make target which is currently broken and non-useful. PR: docs/173971 Submitted by: Derek Wood (pr) diff --git a/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml b/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml index 2930c47..6fecb16 100644 --- a/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml +++ b/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml @@ -257,13 +257,6 @@ - Test the markup using the lint - target. This will quickly find any errors in the document - without actually performing the time-consuming - transformation. - - &prompt.user; make lint - When you are ready to actually build the document, you may specify a single format or a list of formats in the FORMATS variable. Currently, diff --git a/share/mk/doc.xml.mk b/share/mk/doc.xml.mk index a749ae9..a4b1229 100644 --- a/share/mk/doc.xml.mk +++ b/share/mk/doc.xml.mk @@ -373,13 +373,5 @@ ${TARGET.${_ID}}: ${XML.${_ID}} ${DEPENDS.${_ID}} ${XSLTPROC} ${XSLTPROCOPTS.${_ID}} \ -o ${.TARGET} ${PARAMS.${_ID}} \ ${XSLT.${_ID}} ${XML.${_ID}} - -VALIDATE_DOCS+= VALIDATE.${_ID} -VALIDATE.${_ID}: - @${ECHO} "==>[xmllint] ${XML.${_ID}}" - -@${XMLLINT} ${XMLLINTOPTS} ${XML.${_ID}} 2>&1 \ - | ${SED} -e 's/^/ | /' . endfor .endfor - -lint: ${VALIDATE_DOCS} -- Eitan Adler