From owner-cvs-all  Thu Feb  8 15:21:20 2001
Delivered-To: cvs-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 618)
	id 8135E37C191; Thu,  8 Feb 2001 15:21:01 -0800 (PST)
Subject: Re: cvs commit: src/sys/net if_ethersubr.c
In-Reply-To: <20010208235146.E50305@daemon.ninth-circle.org> from Jeroen Ruigrok/Asmodai at "Feb 8, 2001 11:51:46 pm"
To: asmodai@wxs.nl (Jeroen Ruigrok/Asmodai)
Date: Thu, 8 Feb 2001 15:21:01 -0800 (PST)
Cc: archie@FreeBSD.org, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-Id: <20010208232101.8135E37C191@hub.freebsd.org>
From: wpaul@FreeBSD.ORG (Bill Paul)
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> -On [20010208 19:00], Archie Cobbs (archie@FreeBSD.org) wrote:
> >  Log:
> >  When we receive an incoming Ethernet frame that was unicast to a
> >  different hardware address, we should drop it (this should only
> >  happen in promiscuous mode).
> 
> You mean:
> 
> In promiscuous mode we don't drop it?  Whilst in normal mode we drop the
> erroneous unicast frame?
> 
> The sentence is a bit ambiguous to my eyes, hence the call for
> clarification.

I'm hoping he means: "this should only happen if the IFF_PROMISC flag
is set on the interface." Sounds like a sanity check to me -- ideally
the driver should not let this happen -- but I agree, this explanation
should be clearer.

-Bill 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message