From owner-svn-src-head@FreeBSD.ORG Sun Oct 13 16:18:44 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 13B87427; Sun, 13 Oct 2013 16:18:44 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D6B992A48; Sun, 13 Oct 2013 16:18:43 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1VVONO-0008FQ-6S; Sun, 13 Oct 2013 16:18:42 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r9DGIdLk024622; Sun, 13 Oct 2013 10:18:39 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19iRUu+GslKjGknRaULi0dp Subject: Re: svn commit: r256377 - in head: etc/defaults etc/rc.d share/examples/kld/random_adaptor share/man/man4 sys/boot/forth sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe ... From: Ian Lepore To: Mark R V Murray In-Reply-To: <812C1C64-75B0-4FE9-8FCD-B25A484448C6@grondar.org> References: <201310121257.r9CCvvjO006546@svn.freebsd.org> <20131013074825.GO41229@kib.kiev.ua> <3B77143C-7D82-4E62-9974-BC2C6846893F@grondar.org> <20131013151359.GR41229@kib.kiev.ua> <812C1C64-75B0-4FE9-8FCD-B25A484448C6@grondar.org> Content-Type: text/plain; charset="us-ascii" Date: Sun, 13 Oct 2013 10:18:39 -0600 Message-ID: <1381681119.42859.33.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: Konstantin Belousov , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Mark Murray X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Oct 2013 16:18:44 -0000 On Sun, 2013-10-13 at 16:18 +0100, Mark R V Murray wrote: > On 13 Oct 2013, at 16:13, Konstantin Belousov wrote: > > Surely this works, thank you. The rwfile.c content probably should be > > taken under the #ifdef RANDOM_RWFILE. > > OK - thanks for the feedback! > > > But I do not see much use for the randomdev_read_file() and > > randomdev_write_file() functions. It would be better to directly code > > the VFS calls in the random_harvestq_cache(). For one thing, it would > > eliminate unneccessary close and open of the entropy file. > > There is some uncertainty about the future of that code, so I want > to keep it that way for now. Writing files from the kernel is making so@ > very uncomfortable, and there is too much scope for error there. > Indeed, it makes me nervous too, as a heavy user of readonly root filesystems. If writing this file is so critical that it has to be done by the kernel, then what happens when it fails? Right now it prints an error and continues -- if it is not so critical that failure means panic, then why is the kernel doing it at all? Why is the file even in the root filesystem? /var/db seems to be the right place for a transient file needed by the system. Speaking of errors, that might include things like the current code calling vn_close() with the FREAD flag on a file open for writing. -- Ian > We'll settle it down properly in 11.*. > > M