Date: Fri, 27 Nov 2015 16:14:50 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Dimitry Andric <dimitry@andric.com> Cc: Steve Wills <swills@FreeBSD.org>, Tijl Coosemans <tijl@FreeBSD.org>, Gerald Pfeifer <gerald@pfeifer.com>, freebsd-ports@freebsd.org, Rainer Hurling <rhurlin@gwdg.de> Subject: Re: lang/gcc48 fails to build [on HEAD] Message-ID: <20151127145552.GA19655@ivaldir.etoilebsd.net> In-Reply-To: <12016A2D-DFAB-4363-A2B4-70319D498CF4@andric.com> References: <564040EE.6090504@gwdg.de> <alpine.LSU.2.20.1511091105470.2548@anthias> <5642362C.7000609@gwdg.de> <20151127125954.GA17547@ivaldir.etoilebsd.net> <20151127142405.20af4925@kalimero.tijl.coosemans.org> <20151127134205.GB17547@ivaldir.etoilebsd.net> <56586B7D.3080700@FreeBSD.org> <12016A2D-DFAB-4363-A2B4-70319D498CF4@andric.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--sXc4Kmr5FA7axrvy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Nov 27, 2015 at 03:47:21PM +0100, Dimitry Andric wrote:
> On 27 Nov 2015, at 15:41, Steve Wills <swills@FreeBSD.org> wrote:
> On 11/27/2015 08:42, Baptiste Daroussin wrote:
> >> On Fri, Nov 27, 2015 at 02:24:05PM +0100, Tijl Coosemans wrote:
> ...
>=20
> >>> so I was thinking of adding something like this to
> >>> bsd.port.mk:
> >>>=20
> >>> USE_LOCALE?=3D C
> >>> LANG=3D ${USE_LOCALE}
> >>> LC_ALL=3D ${USE_LOCALE}
> >>> .export LANG LC_ALL
> >>>=20
> >>> This gives a consistent locale environment for port builds. Some por=
ts
> >>> already set LANG or LC_ALL. That would have to be reviewed and I hav=
en't
> >>> had time for that yet.
> >>=20
> >> yeah we should imho to that. The same issue appears with GNU tr which =
also
> >> do not take in account collation (IIRC) while ours do.
> >=20
> > FWIW, I ran into this building devel/arm-none-eabi-gcc too. Setting
> > LC_ALL and LANG fixed it for me. Also, Mk/bsd.ruby.mk got something
> > similar for gem builds a while ago, though it uses en_US.UTF-8 for
> > LC_ALL and LC_CTYPE=3DUTF-8. As I recall, this was due to difference in
> > generated docs based on language. We may want to remove the bits from
> > Mk/bsd.ruby.mk if we add it globally. Also, I wonder what impacts this
> > will have beyond fixing builds, such as docs, plist differences or baked
> > in defaults, etc.
>=20
> This really sounds like it needs an exp-run. :-)
An exp-run is really not needed here (will be issued anyway) given when doi=
ng
exp-run, the locale is the default aka C. and an exp-run was made before
importing that code.
Bapt
--sXc4Kmr5FA7axrvy
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlZYc2oACgkQ8kTtMUmk6EzaYwCfTCewYYm1lhaKTu1riC/EjYhG
lYIAoIoB8hPkY8k1pZAPsR61NHQraJMm
=Blsn
-----END PGP SIGNATURE-----
--sXc4Kmr5FA7axrvy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151127145552.GA19655>