Date: Thu, 18 Jul 2002 13:09:51 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: John Baldwin <jhb@FreeBSD.org>, <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org> Subject: RE: cvs commit: src/sys/kern kern_condvar.c kern_shutdown.c kern Message-ID: <20020718130618.N7388-100000@gamplex.bde.org> In-Reply-To: <15669.27952.598634.585316@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 17 Jul 2002, Andrew Gallatin wrote: > Bruce Evans writes: > In terms of bitrot removal in the comments, would the removal of the > second sentence of the following comment in both msleep() and its > clone in cv_timedwait() be sufficient? > > > /* > * During autoconfiguration, just give interrupts > * a chance, then just return. > * Don't run any other procs or panic below, > * in case this is the idle process and already asleep. > */ > > > Becomes: > > /* During autoconfiguration, just return */ > I've left caveats about this in my version until the problems are fully understood. I would prefer a KASSERT that this code is not reached. %%% Index: kern_synch.c =================================================================== RCS file: /home/ncvs/src/sys/kern/kern_synch.c,v retrieving revision 1.185 diff -u -1 -r1.185 kern_synch.c --- kern_synch.c 14 Jul 2002 03:43:33 -0000 1.185 +++ kern_synch.c 17 Jul 2002 12:31:32 -0000 @@ -482,5 +574,9 @@ * After a panic, or during autoconfiguration, - * just give interrupts a chance, then just return; + * then just return; * don't run any other procs or panic below, * in case this is the idle process and already asleep. + * XXX: this used to do "s = splhigh(); splx(safepri); + * splx(s);" to give interrupts a chance, but there is + * no way to give interrupts a chance now. + * XXX2: this can't be the idle process. */ %%% Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020718130618.N7388-100000>