Date: Mon, 8 Sep 2014 21:43:24 +0100 From: Tom Jones <jones@sdf.org> To: George Neville-Neil <gnn@neville-neil.com> Cc: FreeBSD Net <freebsd-net@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, "Eggert, Lars" <lars@netapp.com> Subject: Re: Patches for RFC6937 and draft-ietf-tcpm-newcwv-00 Message-ID: <20140908204322.GA16129@gmail.com> In-Reply-To: <1BF6E077-0B47-41C9-8B47-848E048517B4@neville-neil.com> References: <B7145157-9A03-4053-BFCC-627633E20122@neville-neil.com> <814E0886-1B6B-4316-8BAB-684DAFDE1983@netapp.com> <20140826145517.GD12732@gmail.com> <CAJ-Vmo=TsqAKUrV3BRAk1bX9E1zKq7j5og5CHv4PEz-9sqXpAA@mail.gmail.com> <76D986F7-72A8-4ABE-8731-064C6C77A56F@netapp.com> <CAJ-VmokSzvGyUnSkakrgxizQ1xXOMQgzrXKQMTUuFAZOMG0W=g@mail.gmail.com> <3ABE6D0D-1D98-425B-BDAD-8D1B9026AD8F@netapp.com> <CAJ-Vmo=ogFcwmiKF7WiWW2Z77CwsZ0Ypx0Z2d02OW0igidj1kQ@mail.gmail.com> <4F10C5BC-03B2-486D-A5EF-C55582869ED1@netapp.com> <1BF6E077-0B47-41C9-8B47-848E048517B4@neville-neil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Folks, On Thu, Aug 28, 2014 at 12:39:09PM -0400, George Neville-Neil wrote: > Adrian, >=20 > Can you put this into a Phabricator for review? >=20 > Lars, >=20 > How have you been testing this? Did the newcwv patch make its way into Phabricator? I don't think I would h= ave seen if it did. >=20 > On 27 Aug 2014, at 4:01, Eggert, Lars wrote: >=20 > > Yep > > > > On 2014-8-27, at 9:53, Adrian Chadd <adrian@freebsd.org> wrote: > > > >> Ok. Is it the same patch you sent out in Feb? > >> > >> > >> -a > >> > >> > >> On 27 August 2014 00:43, Eggert, Lars <lars@netapp.com> wrote: > >>> Not as far as I know. > >>> > >>> Lars > >>> > >>> On 2014-8-27, at 9:39, Adrian Chadd <adrian@freebsd.org> wrote: > >>> > >>>> Is there a PR for it? > >>>> > >>>> > >>>> -a > >>>> > >>>> > >>>> On 27 August 2014 00:23, Eggert, Lars <lars@netapp.com> wrote: > >>>>> It would be great if people could also review Aris' PRR patch - RFC= 6937 has been out for a while. > >>>>> > >>>>> Lars > >>>>> > >>>>> > >>>>> > >>>>> > >>>>> On 2014-8-26, at 20:09, Adrian Chadd <adrian@freebsd.org> wrote: > >>>>> > >>>>>> Hi! > >>>>>> > >>>>>> I'm going to merge Tom's work in a week unless someone gives me a > >>>>>> really good reason not to. > >>>>>> > >>>>>> I think there's been enough work and discussion about it since the > >>>>>> first post from Lars in Feburary and enough review opportunity. > >>>>>> > >>>>>> > >>>>>> -a > >>>>>> > >>>>>> > >>>>>> On 26 August 2014 07:55, Tom Jones <jones@sdf.org> wrote: > >>>>>>> On Tue, Aug 26, 2014 at 02:43:49PM +0000, Eggert, Lars wrote: > >>>>>>>> Hi, > >>>>>>>> > >>>>>>>> the newcwv patch is probably stale now with Tom Jones' recent pa= tch based on > >>>>>>>> a more up-to-date version of the Internet-Draft, but the PRR pat= ch should > >>>>>>>> still be useful? > >>>>>>> > >>>>>>> My newcwv patch is much more up to date than Aris's, but it is sl= ightly > >>>>>>> different in implementation. I have had a few suggestions from Ad= rian, but he > >>>>>>> couldn't comment on how it relates to the tcp internals. > >>>>>>> > >>>>>>> There is a PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id= =3D191520 > >>>>>>> > >>>>>>> The biggest difference in structure between mine and Aris's patch= is the use of > >>>>>>> tcp timers. It would be good to hear if my approach or Aris's is = prefered. > >>>>>>> > >>>>>>>> On 2014-6-19, at 23:35, George Neville-Neil <gnn@neville-neil.co= m> wrote: > >>>>>>>> > >>>>>>>>> On 4 Feb 2014, at 1:38, Eggert, Lars wrote: > >>>>>>>>> > >>>>>>>>>> Hi, > >>>>>>>>>> > >>>>>>>>>> below are two patches that implement RFC6937 ("Proportional Ra= te Reduction for TCP") and draft-ietf-tcpm-newcwv-00 ("Updating TCP to supp= ort Rate-Limited Traffic"). They were done by Aris Angelogiannopoulos for h= is MS thesis, which is at https://eggert.org/students/angelogiannopoulos-th= esis.pdf. > >>>>>>>>>> > >>>>>>>>>> The patches should apply to -CURRENT as of Sep 17, 2013. (Sorr= y for the delay in sending them, we'd been trying to get some feedback from= committers first, without luck.) > >>>>>>>>>> > >>>>>>>>>> Please note that newcwv is still a work in progress in the IET= F, and the patch has some limitations with regards to the "pipeACK Sampling= Period" mentioned in the Internet-Draft. Aris says this in his thesis abou= t what exactly he implemented: > >>>>>>>>>> > >>>>>>>>>> "The second implementation choice, is in regards with the meas= urement of pipeACK. This variable is the most important introduced by the m= ethod and is used to compute the phase that the sender currently lies in. I= n order to compute pipeACK the approach suggested by the Internet Draft (ID= ) is followed [ncwv]. During initialization, pipeACK is set to the maximum = possible value. A helper variable prevHighACK is introduced that is initial= ized to the initial sequence number (iss). prevHighACK holds the value of t= he highest acknowledged byte so far. pipeACK is measured once per RTT meani= ng that when an ACK covering prevHighACK is received, pipeACK becomes the d= ifference between the current ACK and prevHighACK. This is called a pipeACK= sample. A newer version of the draft suggests that multiple pipeACK sampl= es can be used during the pipeACK sampling period." > >>>>>>>>>> > >>>>>>>>>> Lars > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> [prr.patch] > >>>>>>>>>> > >>>>>>>>>> [newcwv.patch] > >>>>>>>>> > >>>>>>>>> Apologies for not looking at this as yet. It is now closer to = the top of my list. > >>>>>>>>> > >>>>>>>>> Best, > >>>>>>>>> George > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> -- > >>>>>>> Tom > >>>>>>> @adventureloop > >>>>>>> adventurist.me > >>>>>>> > >>>>>>> :wq > >>>>>>> _______________________________________________ > >>>>>>> freebsd-net@freebsd.org mailing list > >>>>>>> http://lists.freebsd.org/mailman/listinfo/freebsd-net > >>>>>>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd= =2Eorg" > >>>>> > >>>>> > >>> --=20 Tom @adventureloop adventurist.me #pragma summon cthulhu :wq --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: GPGTools - https://gpgtools.org iQIcBAABCgAGBQJUDhTqAAoJEDetXgJOHpB8fzwP/AqV5GMjRMm5YJfTeUSYue2d TjJ9cMl+7tB64WDOM07Ugs6doO4dplpKHy4Ek9vdfhg5MVt5ZarW+bNT6tAfmcP/ rBCsltMgGqS5c4CtHP0knHA8ekfSpsGtOln+sfqwVyezl2Lbw+BDGWYZ1eKnN5sW cawm8ICTqOA9VSbRRYVPYeJdmia2SIcySz+DC/1g3o2qx8Dh2kDI6czli4XR/vLR mVBxXf2czo94cfpRxxQkCmEiSD7JiXQjGeglGYvmtAoQraM1ocEuTbbTtuAVNMN2 mTjOrEIW6eSKNX6HN/HNeGSH4Idv4eYoYdDsyz/RhydycutOdXjyvM5jaW5MMDee pAumFxoX+YNOuujUjzDiXVFnwpXyI7jEtOgpFUfY2jVXl03QfnJszsQNrucm/isT tkVAp96Pzx+wNhoZQw9+ghA77nZZRk1/klDtMwLi7F3ACtKg8SP1WQg8yyUt+3aO vSLQcb+MMabGofNRRpHtcG3ZnRT3nc3eSeUvPGxVo8CQpPNE2kaB2TNNYkqnpYab 5Or4oh/u+ph2FKSESDURyRvNEf6epzFUU1WmyCvobADDJw5hYKF9zi7+QgZKEb2O ga5ASpIO4kZi5XZGabkP8R+MQ22LHoCTtqKDFIp4DKvFLPHhOw5/Tw/3iB9SCf1k bh5kfnvX0OUTqxNMtEOu =8JFh -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140908204322.GA16129>