Date: Tue, 14 Aug 2001 12:16:19 +0100 From: "Nick Hibma" <n_hibma@qubesoft.com> To: "Julian Elischer" <julian@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: RE: cvs commit: src/sys/dev/usb uhub.c Message-ID: <CEEKLNFIGKODPCCPEKLDKEGGCBAA.n_hibma@qubesoft.com> In-Reply-To: <200108101732.f7AHWCq57068@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is not the correct way to do it. usbd_devinfo should allocate the buffer and return it. All drivers should be adapted to use an allocated buffer. Nick > -----Original Message----- > From: owner-cvs-committers@FreeBSD.org > [mailto:owner-cvs-committers@FreeBSD.org]On Behalf Of Julian Elischer > Sent: 10 August 2001 18:32 > To: cvs-committers@FreeBSD.org; cvs-all@FreeBSD.org > Subject: cvs commit: src/sys/dev/usb uhub.c > > > julian 2001/08/10 10:32:12 PDT > > Modified files: > sys/dev/usb uhub.c > Log: > Do NOT allocate a 1K buffer on the kernel stack. > > Found by: Smashed u-area and hardware watch points. > MFC after: 1 week > > Revision Changes Path > 1.29 +13 -3 src/sys/dev/usb/uhub.c > > > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/usb/uhub.c?r > 1=1.28&r2=1.29&cvsroot=freebsd > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CEEKLNFIGKODPCCPEKLDKEGGCBAA.n_hibma>