Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 8 Jun 2002 21:54:27 -0400
From:      Mike Barcroft <mike@FreeBSD.org>
To:        Giorgos Keramidas <keramida@FreeBSD.org>
Cc:        audit@FreeBSD.org
Subject:   Re: warns fixes for bin/date
Message-ID:  <20020608215427.C87326@espresso.q9media.com>
In-Reply-To: <20020609013953.GA71960@hades.hell.gr>; from keramida@FreeBSD.org on Sun, Jun 09, 2002 at 04:39:53AM %2B0300
References:  <20020609013953.GA71960@hades.hell.gr>

next in thread | previous in thread | raw e-mail | index | archive | help
Giorgos Keramidas <keramida@FreeBSD.org> writes:
> The type of a variable passed to getsockopt and recvfrom in
> src/bin/date/netdate.c is `int'.  Changing it to `socklen_t'
> fixes the only warnings that this utility has when compiling
> with WARNS=6.
> 
> How does this look?

I think you might get additional warnings on LP64 system like alpha
and sparc64, since `size_t' != `socklen_t' on those systems.  It's
probably okay to explicitly cast the return values from sizeof() to
`socklen_t' for all the uses of `length'.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020608215427.C87326>