Date: Thu, 22 Feb 2007 13:56:09 -0600 From: "Jeremy Messenger" <mezz7@cox.net> To: "Luigi Rizzo" <rizzo@icir.org> Cc: multimedia@freebsd.org Subject: Re: speex upgrade to 1.1.12 ? Message-ID: <op.tn51nvp99aq2h7@mezz.mezzweb.com> In-Reply-To: <20070222095543.A7555@xorpc.icir.org> References: <20070221073447.A89386@xorpc.icir.org> <op.tn31gkon9aq2h7@mezz.mezzweb.com> <20070221095911.D90766@xorpc.icir.org> <op.tn34fuds9aq2h7@mezz.mezzweb.com> <20070221112414.E91427@xorpc.icir.org> <op.tn372ibm9aq2h7@mezz.mezzweb.com> <op.tn4hkoua9aq2h7@mezz.mezzweb.com> <20070221160312.A94968@xorpc.icir.org> <op.tn5vkdeh9aq2h7@mezz.mezzweb.com> <20070222095543.A7555@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 22 Feb 2007 11:55:43 -0600, Luigi Rizzo <rizzo@icir.org> wrote: > On Thu, Feb 22, 2007 at 11:44:27AM -0600, Jeremy Messenger wrote: > ... >> > http://info.iet.unipi.it/~luigi/FreeBSD/speex-devel-20070221.tgz >> >> Why remove two patches? They are not need anymore? I can build with t= wo > > apparently yes they are not needed anymore. > >> patches w/out any of problem. As for the Makefile, I have done a bit = = >> tweak >> from your changes. Example: >> -PORTVERSION -> DISTVERSION. >> -CONFLICTS=3Dspeex-*, this is incorrect and is too general. It should= be >> speex-[0-9]*. >> -Remove 'devel version' and peroid. An end of peroid in the sentence = is >> illegal in COMMENT. >> -INSTALLS_SHLIB -> USE_LDCONFIG. >> -CONFIGURE_TARGET -> USE_GNOME=3Dgnometarget >> -Add USE_GNOME=3Dltverhack to avoid shared library version bump to of= ten = >> by >> fix libtool bug. FYI: The result is libspeex.so.1 now instead of libspeex.so.[3|5]. >> -Add CONFIGURE_ENV by add -I/-L${LOCALBASE}/[...] to make it works wh= en >> install speex in the different prefix. > > fine, most of the things you note below were just inherited from > the previous one (PORTVERSION, CONFIGURE_TARGET, INSTALL_SHLIBS). > >> -Remove MAKE_ENV, I don't think it is need. > > LDFLAGS was added because some of the code uses the math library and > -lm is not included by default on my box at least (RELENG_6). > Maybe some of the other changes you made also imply -lm ? It was from configure that added -lm by itself. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D checking for sin in -lm... yes [...] cc -shared[...]-L/usr/local/lib -lm -Wl,-soname -Wl,libspeex.so.1 -o = .libs/libspeex.so.1 [...] /bin/sh[...]libspeex.la -lm [...goes on...] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D In the configure's test looks like: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D /* Override any gcc2 internal prototype to avoid an error. */ #ifdef __cplusplus extern "C" #endif /* We use char because int might match the return type of a gcc2 builtin and then its argument prototype would still apply. */ char sin (); int main () { sin (); ; return 0; } =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Have you check in your log to see why it doesn't add -lm yet? > CFLAGS were just added to build with stricter compiler flags, > so it is not strictly necessary; Yep. I have committed speex-devel update. I can do speex-devel -> speex in th= is = weekend. It will be require for me to chase these ports that depend on = speex for shared library version change, bump them, and etc. Cheers, Mezz >> I am not done (have to go back to class soon) with it yet, so if you = = >> have >> any of question then let me know. > > nothing else. > > cheers > luigi -- = mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team - FreeBSD Multimedia Hat (ports, not src) http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org http://wiki.freebsd.org/multimedia - multimedia@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.tn51nvp99aq2h7>