Date: Thu, 13 Mar 2008 10:12:38 -0400 From: Coleman Kane <cokane@FreeBSD.org> To: John Baldwin <jhb@freebsd.org>, freebsd-arch@freebsd.org Cc: imp@FreeBSD.org, obrien@FreeBSD.org Subject: Re: SMPTODO: remove timeout(9) from ffs_softdep.c Message-ID: <47D93656.2000203@FreeBSD.org> In-Reply-To: <200803121058.04096.jhb@freebsd.org> References: <47D7C25D.5070908@cokane.org> <200803120945.29018.jhb@freebsd.org> <47D7E5BF.2060102@cokane.org> <200803121058.04096.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
> On Wednesday 12 March 2008 10:16:31 am Coleman Kane wrote:
>
>> I am attaching the revised patch.
>>
>
> Looks good. I would perhaps not add the extra {}'s around the single-line if
> clauses as it slightly obfuscates the diff (style(9) actually suggests no
> {}'s in that case, but I think in practice our sources have a mixture of
> both).
>
I'm going to commit the attached patch to ffs_softdep.c this afternoon
(EDT) if there aren't any objections. Thanks for the thrice-over guys,
you've been very helpful.
--
Coleman Kane
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47D93656.2000203>