Date: Tue, 18 Jan 2011 20:51:12 +0300 From: Sergey Kandaurov <pluknet@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: perryh@pluto.rain.com, freebsd-stable@freebsd.org, avg@freebsd.org Subject: Re: Could MSGBUF_SIZE be made a loader tunable? Message-ID: <AANLkTi=d4bLP7E2oBGHFB9hUVkBA%2B7D990Dwm38c7NqA@mail.gmail.com> In-Reply-To: <201101181119.42053.jhb@freebsd.org> References: <4cfc72a5.3nAjkv8mdrO/NrKQ%perryh@pluto.rain.com> <4d3261bc.dcI6EuBnzRqvyRnz%perryh@pluto.rain.com> <AANLkTinz8WdEc%2B9xhceEuA0UbG0m0oaokq8FQnUzOTV5@mail.gmail.com> <201101181119.42053.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18 January 2011 19:19, John Baldwin <jhb@freebsd.org> wrote: > On Sunday, January 16, 2011 12:24:27 pm Sergey Kandaurov wrote: >> On 16 January 2011 06:10, =A0<perryh@pluto.rain.com> wrote: >> > Anyone had a chance to look at this? >> > >> > http://lists.freebsd.org/pipermail/freebsd-stable/2010-December/060793= .html >> >> To ease testing on head I have regenerated the patch >> (against r216594): >> http://plukky.net/~pluknet/patches/msgbufsize.diff > > The one hunk involving tf_rip and PS_STRINGS in amd64 looks to be unrelat= ed. Woops, sorry. Nice catch! > Also, in subr_param.c, you can assume that MSGBUF_SIZE is always defined > and always assign it as the initial value rather than having an #ifdef. Good. > Finally, I would adjust the wording in the manpage to not say that this > modifies the MSGBUF_SIZE option, but that this tunable is the same as > adjusting MSGBUF_SIZE. =A0Other than that I think it is fine. > Right. I think a simple s/Modifies/Overrides/ here will be enough. Thanks for your valuable comments. An updated patch is there: http://plukky.net/~pluknet/patches/msgbufsize.2.= diff I'm going to commit this soon. --=20 wbr, pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=d4bLP7E2oBGHFB9hUVkBA%2B7D990Dwm38c7NqA>