Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 01 Feb 2015 20:38:29 -0600
From:      Eric Badger <eric@badgerio.us>
To:        freebsd-current@freebsd.org
Subject:   Re: Filepaths in VM map for tmpfs files
Message-ID:  <54CEE325.4040903@badgerio.us>
In-Reply-To: <20150131153621.GH42409@kib.kiev.ua>
References:  <54CCEFAB.9040406@badgerio.us> <20150131153621.GH42409@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help

On 01/31/2015 09:36 AM, Konstantin Belousov wrote:
> First, shouldn't the kve_type changed to KVME_TYPE_VNODE as well ?
My thinking is no, because KVME_TYPE_SWAP is in fact the correct type; 
I'd opine that it is better to be transparent than make it look like 
there is an OBJT_VNODE object there. It may be that some programs would 
be confused by VNODE info returned on a SWAP type mapping, though I know 
that dtrace handles it OK.

> Second, note that it is possible that the vnode is recycled, so
> OBJ_TMPFS flag is cleared for tmpfs swap object.  The OBJ_TMPFS_NODE
> flag is still set then.  I am not sure what to do in this case,
> should the type changed to KVME_TYPE_VNODE still, but kve_vn_*
> fields left invalid ?
I think if we changed to KVME_TYPE_VNODE in some cases, it should be 
done in all cases, even if the vnode has been recycled (but leave vp == 
NULL in that case). Though if it is left as KVME_TYPE_SWAP, then that 
concern goes away on its own.

Eric




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54CEE325.4040903>