Date: Thu, 19 Feb 2015 10:37:59 +0100 From: Mathieu Arnold <mat@mat.cc> To: Victor Sudakov <vas@mpeks.tomsk.su>, freebsd-pkg@freebsd.org Subject: Re: "poudriere distclean" complains about /etc/make.conf Message-ID: <C0C2840FF666978F32157E03@atuin.in.mat.cc> In-Reply-To: <20150219031446.GA32820@admin.sibptus.tomsk.ru> References: <20150217043049.GA68755@admin.sibptus.tomsk.ru> <F8556CC1B58CDE1EE7646029@ogg.in.absolight.net> <20150218163739.GA24716@admin.sibptus.tomsk.ru> <D0B4CE058DA7FBAEB1615050@atuin.in.mat.cc> <20150219031446.GA32820@admin.sibptus.tomsk.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 19 f=C3=A9vrier 2015 09:14:46 +0600 Victor Sudakov =
<vas@mpeks.tomsk.su>
wrote:
| Mathieu Arnold wrote:
|> +--On 18 f??vrier 2015 22:37:39 +0600 Victor Sudakov =
<vas@mpeks.tomsk.su>
|> wrote:
|> | Mathieu Arnold wrote:
|> |> |=20
|> |> | I have the following construct in /etc/make.conf but not in
|> |> | /usr/local/etc/poudriere.d/make.conf:
|> |> |=20
|> |> | .if ${.CURDIR:M*/mail/spamassassin} && ${HOST} =3D=3D =
"relay.sibptus.ru"
|> |> | =
EXTRA_PATCHES+=3D/root/patches/Mail-SpamAssassin-3.3.1.sa-cgp.diff:-p1
|> |> | .endif
|> |> |=20
|> |> | When I run "poudriere distclean", it complains about this
|> |> | construct:=20
|> |> |=20
|> |> | WARNING (mail/spamassassin): "/etc/make.conf", line 15:
|> |> | Malformed conditional (${.CURDIR:M*/mail/spamassassin} && ${HOST} =
=3D=3D
|> |> | "relay.sibptus.ru") WARNING (mail/spamassassin):
|> |> | "/usr/share/mk/sys.mk", line 340: if-less endif WARNING
|> |> | (mail/spamassassin): make: fatal errors encountered -- cannot
|> |> | continue
|> |> |=20
|> |> | I have two questions.
|> |> |=20
|> |> | 1. Why does it complain? The conditional seems legit.
|> |>=20
|> |> It seems like it is, but it is not, it should be:
|> |>=20
|> |> .if !empty(.CURDIR:M*/mail/spamassassin) && ${HOST} =3D=3D
|> |> "relay.sibptus.ru"
|> |> =
EXTRA_PATCHES+=3D/root/patches/Mail-SpamAssassin-3.3.1.sa-cgp.diff:-p1
|> |> .endif
|> |>=20
|> |> or
|> |>=20
|> |> .if ${.CURDIR:M*/mail/spamassassin} !=3D "" && ${HOST} =3D=3D
|> |> "relay.sibptus.ru"
|> |=20
|> | Sorry, Mathieu, your advice does not help:
|> |=20
|> | [root@svn ~] poudriere distclean -y
|> | [00:00:00] =3D=3D=3D=3D>> Gathering all expected distfiles for ports =
tree
|> | 'default' WARNING (mail/spamassassin): "/etc/make.conf", line 15:
|> | Malformed conditional (${.CURDIR:M*/mail/spamassassin} !=3D "" && =
${HOST}
|> | =3D=3D "relay.sibptus.ru") WARNING (mail/spamassassin):
|> | "/usr/share/mk/sys.mk", line 340: if-less endif WARNING
|> | (mail/spamassassin): make: fatal errors encountered -- cannot continue =
|>=20
|> Ah, yes, HOST is not defined, it's why it fails, you need to add:
|>=20
|> HOST?=3D
|=20
| Mathieu, what makes you think that HOST is not defined? It's defined
| in the environment and should be available to make:
|=20
| [sudakov@relay ~] make -V HOST
| relay.sibptus.ru
| [sudakov@relay ~]
It's not defined in my environment, so I'd say it's specific to your setup,
so, it's not defined when poudriere runs make, so it fails.
--=20
Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C0C2840FF666978F32157E03>