Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Jan 1998 02:27:21 +0100
From:      Eivind Eklund <eivind@yes.no>
To:        dennis <dennis@etinc.com>
Cc:        Eivind Eklund <perhaps@yes.no>, Tom <tom@sdf.com>, Jamie Bowden <jamie@itribe.net>, hackers@FreeBSD.ORG
Subject:   Re: FreeBSD Netcards
Message-ID:  <19980113022721.32158@follo.net>
In-Reply-To: <3.0.32.19980112201715.00a43cb0@etinc.com>; from dennis on Mon, Jan 12, 1998 at 08:17:15PM -0500
References:  <3.0.32.19980112201715.00a43cb0@etinc.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 12, 1998 at 08:17:15PM -0500, dennis wrote:
> At 10:38 PM 1/12/98 +0100, Eivind Eklund wrote:
>> dennis <dennis@etinc.com> writes:
>>> Just look in raw_usrreq(). the default case is a panic. 
>> 
>> Fixed in revision 1.12 as of April 27, 1997.
>> 
>> Do you have anything else?  (I don't think any of us want panic()s to
>> occur for userland errors, though I think they often are the correct
>> path for a kernel error.)
> 
> 2.2.5-RELEASE is shipped with v1.8 which is dated 3/11/96, so
> something is amiss. If it takes a year for these fixes to make it
> into a release it doesnt do anyone any good...

Well, this was fixed as a part of a major rewrite of that part of the
code.  The patch that fixes this is actually twice as large as the
raw_usrreq file.  I also _think_ it links in with more modifications
elsewhere, but I haven't looked to closely - it came in in a
mega-commit, at least.

At least be happy it is fixed in 3.0 :-)

Do you have any other cases of panic() being used incorrectly?

Eivind.






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980113022721.32158>