Date: Mon, 20 Feb 2006 21:53:49 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Alexander Nedotsukov <bland@freebsd.org> Cc: gnome@freebsd.org Subject: Re: Eog Crash while opening jpeg-images with EXIF data Message-ID: <1140490429.65763.3.camel@shumai.marcuscom.com> In-Reply-To: <43FA7D9F.5090108@FreeBSD.org> References: <1140487656.847.6.camel@synergy.odyssey.homeunix.org> <43FA7D9F.5090108@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-KL2WdFBfhaMnO2kavOUV Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2006-02-21 at 11:40 +0900, Alexander Nedotsukov wrote: > Pascal, > Cast it to (char*) instead. And this is not the only place in that file.=20 > You have to patch other memcpy()s too. I think guchar * would be more apt, no? Joe > All the best, > Alexander. > Pascal Hofstee wrote: > > i am noticing a consistent eog crash when opening jpeg images with EXIF > > data (using MC-gnome, eog-2.13.91) on FreeBSD/amd64 7.0-CURRENT > > > > The line that causes the crash is libeog/eog-metadata-reader.c:231 > > > > memcpy ((void*) ((int)(priv->exif_chunk) + priv->bytes_read), > > (void*)&buf[i], priv->size); > > > > I am about 99% sure the (int) typecast on priv->exit_chunk is truncatin= g > > the 64-bit pointer into 32-bits causing the application to segfault as = a > > result. I am not 100% on how to properly fix this. > > > > If any of you could have a look at this, that would be appreciated. > > > > =20 >=20 > _______________________________________________ > freebsd-gnome@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-gnome > To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@freebsd.org" >=20 --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-KL2WdFBfhaMnO2kavOUV Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (FreeBSD) iD8DBQBD+oC9b2iPiv4Uz4cRAmu7AJ9YelUhT7bxERhJwzjh5E5EEbWwkQCfQi+J wtgyUzQ6YOiSLNGcV3C18hg= =rUCo -----END PGP SIGNATURE----- --=-KL2WdFBfhaMnO2kavOUV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1140490429.65763.3.camel>