Date: Sun, 29 Oct 2017 11:25:45 -0700 From: Kirk McKusick <mckusick@mckusick.com> To: Stefan Esser <se@freebsd.org> Cc: Mark Johnston <markj@FreeBSD.org>, freebsd-fs@FreeBSD.org Subject: Re: softdep as a mount(8) option Message-ID: <201710291825.v9TIPjRE095791@chez.mckusick.com> In-Reply-To: <659abe72-69f9-8e89-24ba-36a9fdfb3fd5@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Your patch will require some additional work now that we have journalled soft updates. The issue is that when journalled soft updates are in use, the FS_DOSOFTDEP flag will be set for the filesystem as it is a prerequisite for journalling. If you turn off the FS_DOSOFTDEP flag while journalling is enabled very bad things will happen (hopefully just a kernel panic and not irrecoverable filesystem state). So, additional changes are needed to check for the FS_SUJ flag being set, and if it is, to disallow the disabling of the FS_DOSOFTDEP flag by the mount of the filesystem. Kirk McKusick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201710291825.v9TIPjRE095791>