Date: Wed, 4 Apr 2001 08:54:47 -0700 From: "Matthew H. North" <ctsmhn@cts.com> To: "Bruce Evans" <bde@zeta.org.au> Cc: <freebsd-fs@FreeBSD.ORG> Subject: RE: Reproducible kernel panics in ffs_valloc: dup_alloc Message-ID: <LAEKJNMMIOPFCDDPFBDEIECBCBAA.ctsmhn@cts.com> In-Reply-To: <Pine.BSF.4.21.0104042236010.40022-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks for the help. However, from my understanding of C, that patch does
nothing (except add an extra instruction or two to the kernel). It simply
adds an extra OR condition, that is always false, to an if statement.
if CONDITION then
do something
is exactly the same as
if FALSE or CONDITION then
do something
Perhaps I'm missing something. If so, please let me know.
I am interested in your comment about, "...longstanding bugs in
vfs_bio_clrbuf()...." Is there somewhere I can find a history of these bugs
and patches?
- Matt
| -----Original Message-----
| From: Bruce Evans [mailto:bde@zeta.org.au]
| Sent: Wednesday, April 04, 2001 5:41 AM
| To: Matthew H. North
| Cc: freebsd-fs@FreeBSD.ORG
| Subject: Re: Reproducible kernel panics in ffs_valloc: dup_alloc
|
|
| On Tue, 3 Apr 2001, Matthew H. North wrote:
|
| > After spending hours trouble-shooting this and looking for
| similar problems
| > and solutions in the bug archive, google, etc., I'm running out
| of ideas.
| >
| > I am responsible for maintaining a squid cache system for my company.
| > Currently, the system is: PIII/800MHz, 768MB RAM (1GB cache), FreeBSD
| > 4.2-STABLE, Squid-2.3STABLE4 (compiled locally instead of using
| the FreeBSD
| > port). Boot drive and Squid cache drives are SCSI-LVD running
| at 80MB/s off
| > of the Adaptec 29160N card. Softupdates are not enabled on *any* of the
| > drives in this system.
| >
| > Unfortunately this system has been plagued by kernel panics for
| a number of
| > weeks now. I originally assumed there was some sort of
| hardware problem,
| > but I've since replaced every last piece of hardware: MB, RAM, CPU, SCSI
| > card, SCSI cable, SCSI drives, video card, NICs. Every last piece of
| > hardware has been replaced, yet the kernel panics persists on a fairly
| > regular basis.
|
| I wonder if the longstanding bugs in vfs_bio_clrbuf() could cause this
| problem (rev.1.188 of vfs_bio.c fixed only some of the bugs). Quick fix:
|
| Index: vfs_bio.c
| ===================================================================
| RCS file: /home/ncvs/src/sys/kern/vfs_bio.c,v
| retrieving revision 1.273
| diff -u -2 -r1.273 vfs_bio.c
| --- vfs_bio.c 2001/02/28 04:13:07 1.273
| +++ vfs_bio.c 2001/04/04 12:35:26
| @@ -3088,5 +3088,5 @@
| int i, mask = 0;
| caddr_t sa, ea;
| - if ((bp->b_flags & (B_VMIO | B_MALLOC)) == B_VMIO) {
| + if (0 || (bp->b_flags & (B_VMIO | B_MALLOC)) == B_VMIO) {
| bp->b_flags &= ~B_INVAL;
| bp->b_ioflags &= ~BIO_ERROR;
|
|
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-fs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?LAEKJNMMIOPFCDDPFBDEIECBCBAA.ctsmhn>